Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Rollup merge of #136127 - WaffleLapkin:dyn_ptr_unwrap_cast, r=compiler-errors" #138892

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Revert "Rollup merge of #136127 - WaffleLapkin:dyn_ptr_unwrap_cast, r=compiler-errors" #138892

merged 1 commit into from
Mar 31, 2025

Conversation

compiler-errors
Copy link
Member

...not permanently tho. Just until we can land something like #138542, which will fix the underlying perf issues (#136127 (comment)). I just don't want this to land on beta and have people rely on this behavior if it'll need some reworking for it to be implemented performantly.

r? @WaffleLapkin or reassign -- sorry for reverting ur pr! i'm working on getting it re-landed soon :>

@compiler-errors
Revert "Rollup merge of rust-lang#136127 - WaffleLapkin:dyn_ptr_unwra…
e06d50c 
…p_cast, r=compiler-errors"

This reverts commit 84c2050, reversing
changes made to a96fa31.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Mar 31, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Mar 31, 2025

📌 Commit e06d50c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2025
@bors
Copy link
Collaborator

bors commented Mar 31, 2025

⌛ Testing commit e06d50c with merge ab5b1be...

@bors
Copy link
Collaborator

bors commented Mar 31, 2025

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ab5b1be to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2025
@bors bors merged commit ab5b1be into rust-lang:master Mar 31, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Mar 31, 2025
@github-actions GitHub Actions
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 10a76d6 (parent) -> ab5b1be (this PR)

Test differences

Show 10 test diffs

Stage 1

  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap-add-auto.rs: pass -> [missing] (J0)
  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-args.rs: pass -> [missing] (J0)
  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-regions.rs: pass -> [missing] (J0)
  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap.rs: pass -> [missing] (J0)

Stage 2

  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap-add-auto.rs: pass -> [missing] (J1)
  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-args.rs: pass -> [missing] (J1)
  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-regions.rs: pass -> [missing] (J1)
  • [ui] tests/ui/cast/ptr-to-trait-obj-wrap.rs: pass -> [missing] (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-3
  • J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

  1. aarch64-apple: 4091.3s -> 5033.9s (23.0%)
  2. dist-aarch64-apple: 5499.4s -> 6459.9s (17.5%)
  3. aarch64-gnu-debug: 5957.1s -> 6324.8s (6.2%)
  4. dist-i686-mingw: 7932.3s -> 8328.2s (5.0%)
  5. dist-i586-gnu-i586-i686-musl: 5106.1s -> 5305.9s (3.9%)
  6. x86_64-mingw-1: 8953.3s -> 9217.7s (3.0%)
  7. x86_64-gnu-llvm-18-1: 5404.5s -> 5561.8s (2.9%)
  8. dist-aarch64-msvc: 8445.9s -> 8674.1s (2.7%)
  9. i686-gnu-nopt-2: 6435.1s -> 6606.3s (2.7%)
  10. dist-i686-linux: 5968.7s -> 6115.7s (2.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@WaffleLapkin
Copy link
Member

Only noticed the notification now; thanks for working on fixing up my broken stuff, errs 💚

@compiler-errors
Copy link
Member Author

@WaffleLapkin: Hope to fix it fully soon. Thanks for the initial approach, and sorry that we had to revert it due to stupid things like perf >.<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WaffleLapkin WaffleLapkin

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @oli-obk @bors @WaffleLapkin @rustbot