Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run coretests and alloctests with cg_clif in CI #139213

Merged
merged 3 commits into from
Apr 4, 2025
Merged

Run coretests and alloctests with cg_clif in CI #139213

merged 3 commits into from
Apr 4, 2025
+35 −24

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 1, 2025

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 1, 2025
@bjorn3 bjorn3 added A-cranelift Things relevant to the [future] cranelift backend T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 1, 2025
@bjorn3 bjorn3 mentioned this pull request Apr 1, 2025
Open
13 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
Copy link
Member Author

bjorn3 commented Apr 1, 2025

cg_clif's build system passes --cap-lints=allow, but somehow building coretests and alloctests is still emitting warnings.

@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 1, 2025

r? compiler

@rustbot rustbot assigned cjgillot and unassigned BoxyUwU Apr 1, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 1, 2025

r? compiler

@rustbot rustbot assigned lcnr and unassigned cjgillot Apr 1, 2025
@lcnr
Copy link
Contributor

lcnr commented Apr 1, 2025

r? compiler

@rustbot rustbot assigned petrochenkov and unassigned lcnr Apr 1, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 1, 2025

r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned petrochenkov Apr 1, 2025
@bjorn3 bjorn3 force-pushed the cg_clif_test_coretests branch from 7845fc5 to 1397094 Compare April 3, 2025 12:07
@bjorn3
Copy link
Member Author

bjorn3 commented Apr 3, 2025 •
edited
Loading

cg_clif's build system passes --cap-lints=allow, but somehow building coretests and alloctests is still emitting warnings.

Ah, only for the extended_sysroot test suite, but I moved coretests and alloctests to the base_sysroot test suite. Added an explicit --cap-lints=allow for them.

@rustbot ready

@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Apr 3, 2025

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 3, 2025

📌 Commit fde54c2 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 4, 2025
@Zalathar
Rollup merge of rust-lang#139213 - bjorn3:cg_clif_test_coretests, r=j…
078a3e9 
…ieyouxu

Run coretests and alloctests with cg_clif in CI

Part of rust-lang/rustc_codegen_cranelift#1290
@Zalathar Zalathar mentioned this pull request Apr 4, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2025
@bors
Auto merge of rust-lang#139344 - Zalathar:rollup-uklkyeb, r=Zalathar
Loading
Loading status checks…
eb82b07 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#137869 (Demote i686-pc-windows-gnu to Tier 2)
 - rust-lang#137880 (Autodiff batching)
 - rust-lang#138546 (Add integer to string formatting tests)
 - rust-lang#138947 (Refactor Apple version handling in the compiler)
 - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names)
 - rust-lang#139213 (Run coretests and alloctests with cg_clif in CI)
 - rust-lang#139274 (Rustdoc: typecheck settings.js)
 - rust-lang#139295 (Remove creation of duplicate `AnonPipe`)
 - rust-lang#139298 (Allow for missing invisible close delim when reparsing an expression.)
 - rust-lang#139313 (Deduplicate some `rustc_middle` function bodies by calling the `rustc_type_ir` equivalent)
 - rust-lang#139317 (compiletest: Encapsulate all of the code that touches libtest)
 - rust-lang#139322 (Add helper function for checking LLD usage to `run-make-support`)
 - rust-lang#139335 (Pass correct param-env to `error_implies`)
 - rust-lang#139342 (Add a mailmap entry for myself)

Failed merges:

 - rust-lang#138949 (Rename `is_like_osx` to `is_like_darwin`)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 4, 2025
@Zalathar
Rollup merge of rust-lang#139213 - bjorn3:cg_clif_test_coretests, r=j…
3666b2c 
…ieyouxu

Run coretests and alloctests with cg_clif in CI

Part of rust-lang/rustc_codegen_cranelift#1290
@Zalathar Zalathar mentioned this pull request Apr 4, 2025
Closed
@bors
Copy link
Collaborator

bors commented Apr 4, 2025

⌛ Testing commit fde54c2 with merge b8ff7b6...

@bors
Copy link
Collaborator

bors commented Apr 4, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing b8ff7b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2025
@bors bors merged commit b8ff7b6 into rust-lang:master Apr 4, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a4166da (parent) -> b8ff7b6 (this PR)

Test differences

No test diffs found

Job duration changes

  1. x86_64-mingw-2: 6755.7s -> 7622.6s (12.8%)
  2. i686-mingw-1: 7272.5s -> 7833.4s (7.7%)
  3. dist-s390x-linux: 5221.4s -> 5594.9s (7.2%)
  4. x86_64-msvc-2: 6786.4s -> 7252.8s (6.9%)
  5. x86_64-msvc-ext2: 5677.7s -> 5960.2s (5.0%)
  6. dist-i686-msvc: 6797.8s -> 7128.9s (4.9%)
  7. i686-gnu-1: 8512.4s -> 8925.6s (4.9%)
  8. x86_64-gnu-llvm-19-2: 5813.1s -> 6091.1s (4.8%)
  9. dist-x86_64-apple: 8805.9s -> 9223.4s (4.7%)
  10. dist-x86_64-msvc: 6062.7s -> 6292.1s (3.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bjorn3 bjorn3 deleted the cg_clif_test_coretests branch April 4, 2025 16:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b8ff7b6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.3%, -1.6%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.575s -> 781.07s (0.06%)
Artifact size: 365.99 MiB -> 365.97 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu

Assignees

@jieyouxu jieyouxu

Labels
A-cranelift Things relevant to the [future] cranelift backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@bjorn3 @rustbot @rust-log-analyzer @BoxyUwU @lcnr @jieyouxu @bors @rust-timer @cjgillot @petrochenkov