[WIP] run-make-support: Calculate artifact names for target platform, not host platform #139242
+449
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
Reminder, once the PR becomes ready for a review, use |
|
@bors try |
jieyouxu
added
S-waiting-on-author
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
…ss, r=<try> Fix `run-make-support` artifact name calculations for target on cross-compile This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*. Helps with rust-lang#138066. r? `@Kobzol` `@rustbot` author (needs try-jobs) try-job: armhf-gnu try-job: test-various try-job: `*windows*` try-job: `*apple*`
This comment has been minimized.
This comment has been minimized.
Kobzol
reviewed
Apr 2, 2025
Oh it was because initially I saw |
jieyouxu
force-pushed
the
run-make-artifact-names-cross
branch
from
cc4aee9 to
e468241
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
…ss, r=<try> Fix `run-make-support` artifact name calculations for target on cross-compile This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*. Helps with rust-lang#138066. r? `@Kobzol` `@rustbot` author (needs try-jobs) try-job: armhf-gnu try-job: test-various try-job: `*msvc*` try-job: `*mingw*` try-job: `*apple*`
This comment has been minimized.
This comment has been minimized.
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
…ss, r=<try> Fix `run-make-support` artifact name calculations for target on cross-compile This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*. Helps with rust-lang#138066. r? `@Kobzol` `@rustbot` author (needs try-jobs) try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
This is not normally |
|
@bors try |
|
Ah hah, i686-mingw-1 be gone |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
…ss, r=<try> [WIP] run-make-support: Calculate artifact names for target platform, not host platform This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*. Helps with rust-lang#138066. r? `@Kobzol` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
jieyouxu
force-pushed
the
run-make-artifact-names-cross
branch
from
0e57f60 to
9fd69fe
Compare
rustbot
added
A-compiletest
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2025
…ss, r=<try> [WIP] run-make-support: Calculate artifact names for target platform, not host platform > [!CAUTION] > > Stacked on top of rust-lang#139469. This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*. Helps with rust-lang#138066. r? `@Kobzol` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
The `//@ needs-crate-type: $crate_types...` directive takes a comma-separated list of crate types that the target platform must support in order for the test to be run.
…directives Not all existing tests are converted, I only updated ones that I can easily find via directive comments.
This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*.
And ignore on nvptx64.
The linker binary needs to run.
- Ignore nvptx that needs target std. - Ignore targets that don't support cdylib.
jieyouxu
force-pushed
the
run-make-artifact-names-cross
branch
from
9fd69fe to
db12c1b
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2025
…ss, r=<try> [WIP] run-make-support: Calculate artifact names for target platform, not host platform > [!CAUTION] > > Stacked on top of rust-lang#139469. This was implemented incorrectly during the porting process, where we relied on std consts. However, `run-make-support` is a host-only library, which meant that these artifact names were for the *host* and not the *target*. Helps with rust-lang#138066. r? `@Kobzol` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Stacked on top of #139469.
This was implemented incorrectly during the porting process, where we relied on std consts. However,
run-make-supportis a host-only library, which meant that these artifact names were for the host and not the target.Helps with #138066.
r? @Kobzol
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1