Rollup of 5 pull requests #139257

TaKO8Ki · 2025-04-02T13:52:48Z

Successful merges:

Remove cjgillot from automated review assignment #139178 (Remove cjgillot from automated review assignment)
Add unstable --print=crate-root-lint-levels #139184 (Add unstable --print=crate-root-lint-levels)
Add opt-level = "s" for more std symbolication crates #139215 (Add opt-level = "s" for more std symbolication crates)
Move methods from Map to TyCtxt, part 5. #139232 (Move methods from Map to TyCtxt, part 5.)
Remove aux_build run-make rustc helpers #139239 (Remove aux_build run-make rustc helpers)

r? @ghost
@rustbot modify labels: rollup

This eliminates all methods on `Map`. Actually removing `Map` will occur in a follow-up PR.

They provide very little value and makes it more confusing than is helpful.

…-assighment, r=cjgillot Remove cjgillot from automated review assignment As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Review.20for.20.23137465/with/508540539). To be clear, this is not a value judgement, it's just a way to improve our fairness when assigning reviews, trying to find a balance between leaving time to Rust contributors review on their terms and availability and avoid having PRs waiting for too long. > [!IMPORTANT] > This is not a final decision! Rust contributors are free to re-add themselves back to the active review rotation (if they feel like it) once they have more availability. cc: `@cjgillot`

…eyouxu Add unstable `--print=crate-root-lint-levels` This PR implements `--print=crate-root-lint-levels` from MCP 833 rust-lang/compiler-team#833. Tracking issue: rust-lang#139180 Best reviewed commit by commit.

Add `opt-level = "s"` for more std symbolication crates This reduces the size of a hello world binary built by stage 1 in release by a few kilobytes

Move methods from `Map` to `TyCtxt`, part 5. This eliminates all methods on `Map`. Actually removing `Map` will occur in a follow-up PR. A follow-up to rust-lang#137504. r? `@Zalathar`

Remove `aux_build` run-make rustc helpers They provide very little value and makes it more confusing than is helpful. Helps with rust-lang#138066. r? `@Kobzol`

TaKO8Ki · 2025-04-02T13:53:02Z

@bors r+ rollup=never p=5

bors · 2025-04-02T13:53:05Z

📌 Commit abcfc3e has been approved by TaKO8Ki

It is now in the queue for this repository.

bors · 2025-04-02T14:17:14Z

⌛ Testing commit abcfc3e with merge 4f0de4c...

bors · 2025-04-02T17:59:14Z

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 4f0de4c to master...

rust-timer · 2025-04-02T18:00:41Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139178	Remove cjgillot from automated review assignment	`f9d53c4223e9a1adada0850e46d83c8280997bf8` (link)
#139184	Add unstable `--print=crate-root-lint-levels`	`8713ba6ec1cda427ae1375a0f62328005ef1e07b` (link)
#139215	Add `opt-level = "s"` for more std symbolication crates	`17108a4cea1d2bee70a1a5f6a5aad90ad51805a7` (link)
#139232	Move methods from `Map` to `TyCtxt`, part 5.	`5c9cf68c2c9b41db1c6d2f1d74d933e389d5f806` (link)
#139239	Remove `aux_build` run-make rustc helpers	`60747784583c15061f1a39e292fe6e887ec0e0d3` (link)

previous master: ae9173d7dd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-04-02T18:01:00Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ae9173d (parent) -> 4f0de4c (this PR)

Test differences

Show 34 test diffs

Stage 1

[run-make] tests/run-make/print-crate-root-lint-levels: [missing] -> pass (J0)
[ui] tests/ui/print-request/stability.rs#crate_root_lint_levels: [missing] -> pass (J0)

Stage 2

[run-make] tests/run-make/print-crate-root-lint-levels: [missing] -> pass (J1)
[ui] tests/ui/print-request/stability.rs#crate_root_lint_levels: [missing] -> pass (J2)

Additionally, 30 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-3
J1: aarch64-apple, aarch64-gnu, aarch64-gnu-debug, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, dist-various-1, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J2: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

aarch64-apple: 4030.5s -> 7599.4s (88.5%)
x86_64-apple-1: 6368.2s -> 10702.2s (68.1%)
dist-x86_64-apple: 9179.4s -> 12579.4s (37.0%)
dist-apple-various: 7429.5s -> 9655.5s (30.0%)
dist-x86_64-linux: 4877.5s -> 5564.4s (14.1%)
x86_64-gnu-llvm-19-3: 6631.2s -> 7144.1s (7.7%)
x86_64-gnu-distcheck: 4411.0s -> 4725.9s (7.1%)
x86_64-mingw-2: 6820.8s -> 7252.4s (6.3%)
i686-msvc-1: 9387.3s -> 9961.8s (6.1%)
dist-loongarch64-musl: 5401.0s -> 5720.8s (5.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-04-02T20:36:26Z

Finished benchmarking commit (4f0de4c): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	13
Regressions ❌ (secondary)	0.2%	[0.1%, 0.6%]	32
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.6%]	4
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	0.1%	[-0.7%, 0.4%]	17

Max RSS (memory usage)

Results (primary 0.9%, secondary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[1.6%, 4.9%]	4
Regressions ❌ (secondary)	3.3%	[2.2%, 5.4%]	3
Improvements ✅ (primary)	-2.2%	[-3.2%, -1.5%]	3
Improvements ✅ (secondary)	-3.0%	[-4.6%, -1.0%]	12
All ❌✅ (primary)	0.9%	[-3.2%, 4.9%]	7

Cycles

Results (primary -0.7%, secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.8%, -0.7%]	3
Improvements ✅ (secondary)	-2.6%	[-3.6%, -1.1%]	7
All ❌✅ (primary)	-0.7%	[-0.8%, -0.7%]	3

Binary size

Results (primary -0.4%, secondary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-2.1%, -0.0%]	40
Improvements ✅ (secondary)	-1.8%	[-2.1%, -0.2%]	45
All ❌✅ (primary)	-0.4%	[-2.1%, 0.0%]	41

Bootstrap: 776.507s -> 776.833s (0.04%)
Artifact size: 366.05 MiB -> 365.93 MiB (-0.03%)

rylev · 2025-04-08T15:56:44Z

Found the cause in #139232 (comment)

@rustbot label: +perf-regression-triaged

Urgau and others added 13 commits March 31, 2025 17:58

Expose LintLevelsBuilder with crate root builder

1238a20

Expose registered_tools directly without TyCtxt-query

69cb0a9

Remove cjgillot from automated review assignment

ebca98f

Add unstable --print=crate-root-lint-levels

df18de5

Add opt-level = "s" for more std symbolication crates

4c92418

Move methods from Map to TyCtxt, part 5.

6713f34

This eliminates all methods on `Map`. Actually removing `Map` will occur in a follow-up PR.

Drop aux_build rustc helpers

b591eb0

They provide very little value and makes it more confusing than is helpful.

Update run-make tests to no longer use aux_build

f31bd74

Rollup merge of rust-lang#139215 - clubby789:std-size-tweaks, r=joboet

5df0c68

Add `opt-level = "s"` for more std symbolication crates This reduces the size of a hello world binary built by stage 1 in release by a few kilobytes

Rollup merge of rust-lang#139232 - nnethercote:remove-Map-5, r=Zalathar

bda2ea4

Move methods from `Map` to `TyCtxt`, part 5. This eliminates all methods on `Map`. Actually removing `Map` will occur in a follow-up PR. A follow-up to rust-lang#137504. r? `@Zalathar`

Rollup merge of rust-lang#139239 - jieyouxu:run-make-aux-build, r=Kobzol

abcfc3e

Remove `aux_build` run-make rustc helpers They provide very little value and makes it more confusing than is helpful. Helps with rust-lang#138066. r? `@Kobzol`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2025

bors merged commit 4f0de4c into rust-lang:master Apr 2, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 2, 2025

rustbot added the perf-regression Performance regression. label Apr 2, 2025

Kobzol mentioned this pull request Apr 2, 2025

Move methods from Map to TyCtxt, part 5. #139232

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #139257

Rollup of 5 pull requests #139257

Uh oh!

TaKO8Ki commented Apr 2, 2025

Uh oh!

TaKO8Ki commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

Uh oh!

rust-timer commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 2, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Apr 2, 2025

Uh oh!

rylev commented Apr 8, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #139257

Rollup of 5 pull requests #139257

Uh oh!

Conversation

TaKO8Ki commented Apr 2, 2025

Uh oh!

TaKO8Ki commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

Uh oh!

rust-timer commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 2, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 2, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rylev commented Apr 8, 2025

Uh oh!

Uh oh!