Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tshepang and others added 30 commits April 3, 2025 02:04
test directive can appear anywhere in the file
add some links about the rustdoc-gui test suite
Update book.toml fix the authors field
Fix deadlink in libs-and-metadata.md
Currently `compiletest` panics all over the place but doesn't really use
`anyhow` anyway. I'd like to introduce some more principled error
handling and disciplined diagnostic reporting in the near future.
Also checked the rest of the mentions of std::mem in the changed file
and they look good to me.
This flag is deprecated in libtest, and there's no evidence in-tree of this
flag actually being passed to compiletest.

(For detailed information about test results, bootstrap parses JSON output from
compiletest instead.)
This will help people notice the `S-tracking-*` labels, and if the
tracking issue *is* implemented, they can change the label.
…r=oli-obk

Restrict some queries by def-kind more

Random cleanup. I prefer things to assert more so as to catch bugs :)

r? oli-obk
…kril

Revert r-a changes of rust-lang#139455

I discovered rust-lang#132735 (comment) that I might have done too much in rust-lang#132735 by also removing support in r-a.
So this reverts the commit with the changes to r-a.

r? RalfJung
add missing word in doc comment (part 2)
Improve presentation of closure signature mismatch from `Fn` trait goal

Flip the order of "expected" and "found" since that wasn't correct.

Don't present the arguments as a tuple, since it leaves a trailing comma. Instead, just use `fn(arg, arg)`.

Finally, be better with binders since we were just skipping binders.

r? oli-obk or reassign
…, r=lqd

compiletest maintenance: sort deps and drop dep on `anyhow`

Two changes:

1. Sort compiletest deps alphabetically because it was annoying me (harder to quickly glance what deps compiletest is using).
2. Drop dependency on `anyhow`. There's only one usage of `anyhow`, which is for `with_context` on sth that would immediately panic anyway.
Rustc dev guide subtree update

r? `@jieyouxu`
@rustbot rustbot added the rollup A PR which is a rollup label Apr 8, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Apr 8, 2025

📌 Commit f2fd24d has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@bors
Copy link
Collaborator

bors commented Apr 8, 2025

⌛ Testing commit f2fd24d with merge a27db8a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 8, 2025
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#139494 (Restrict some queries by def-kind more)
 - rust-lang#139496 (Revert r-a changes of rust-lang#139455)
 - rust-lang#139506 (add missing word in doc comment (part 2))
 - rust-lang#139515 (Improve presentation of closure signature mismatch from `Fn` trait goal)
 - rust-lang#139520 (compiletest maintenance: sort deps and drop dep on `anyhow`)
 - rust-lang#139523 (Rustc dev guide subtree update)
 - rust-lang#139526 (Fix deprecation note for std::intrinsics)
 - rust-lang#139528 (compiletest: Remove the `--logfile` flag)
 - rust-lang#139541 (Instantiate higher-ranked transmute goal w/ placeholders before emitting sub-obligations)
 - rust-lang#139547 (Update library tracking issue template to set S-tracking-unimplemented)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [assembly] tests\assembly\targets\targets-pe.rs#aarch64_pc_windows_gnullvm stdout ----

error in revision `aarch64_pc_windows_gnullvm`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: 
status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_pc_windows_gnullvm" "--check-cfg" "cfg(test,FALSE,aarch64_pc_windows_msvc,aarch64_pc_windows_gnullvm,aarch64_unknown_uefi,aarch64_uwp_windows_msvc,arm64ec_pc_windows_msvc,avr_none,bpfeb_unknown_none,bpfel_unknown_none,i686_pc_windows_gnu,i686_pc_windows_msvc,i686_pc_windows_gnullvm,i686_uwp_windows_gnu,i686_win7_windows_gnu,i686_unknown_uefi,i686_uwp_windows_msvc,i686_win7_windows_msvc,powerpc64_ibm_aix,thumbv7a_uwp_windows_msvc,thumbv7a_pc_windows_msvc,x86_64_pc_windows_gnu,x86_64_pc_windows_gnullvm,x86_64_pc_windows_msvc,x86_64_unknown_uefi,x86_64_uwp_windows_gnu,x86_64_win7_windows_gnu,x86_64_uwp_windows_msvc,x86_64_win7_windows_msvc,x86_64_pc_cygwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-pe.aarch64_pc_windows_gnullvm\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-pc-windows-gnullvm" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustc9zZsYl"

error: aborting due to 1 previous error
------------------------------------------


---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.32s

Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:38:37
make: *** [Makefile:124: ci-mingw-x] Error 1
  local time: Tue Apr  8 22:49:07 CUT 2025
  network time: Tue, 08 Apr 2025 22:49:07 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Collaborator

bors commented Apr 8, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 8, 2025

Spurious perm error.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. CI-spurious-fail-mingw CI spurious failure: target env mingw S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2025
@matthiaskrgr
Copy link
Member Author

@bors p=6

@bors
Copy link
Collaborator

bors commented Apr 9, 2025

⌛ Testing commit f2fd24d with merge 97c966b...

@bors
Copy link
Collaborator

bors commented Apr 9, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 97c966b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 9, 2025
@bors bors merged commit 97c966b into rust-lang:master Apr 9, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 9, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c1b8b7e (parent) -> 97c966b (this PR)

Test differences

Show 33000 test diffs

Stage 1

  • doctest::tests::check_split_args: [missing] -> pass (J0)
  • errors::verify_ast_lowering_inclusive_range_with_no_end_30: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_failed_to_get_layout_132: [missing] -> pass (J0)
  • errors::verify_expand_module_circular_30: [missing] -> pass (J0)
  • errors::verify_passes_only_has_effect_on_143: [missing] -> pass (J0)
  • errors::verify_passes_rustc_legacy_const_generics_index_66: [missing] -> pass (J0)
  • html::render::tests::test_name_sorting: [missing] -> pass (J0)
  • json::tests::empty: [missing] -> pass (J0)
  • lints::verify_lint_macro_use_deprecated_105: [missing] -> pass (J0)
  • lints::verify_lint_unused_allocation_98: [missing] -> pass (J0)
  • lints::verify_lint_variant_size_differences_88: [missing] -> pass (J0)
  • owned_slice::tests::try_and_fail: [missing] -> pass (J0)
  • parser::tests::different_note_spanned_1: [missing] -> pass (J0)
  • spec::tests::x86_64_unknown_netbsd: [missing] -> pass (J0)
  • ascii::test_is_ascii_align_size_thoroughly: [missing] -> pass (J1)
  • c_str2::from_bytes_with_nul_unterminated: [missing] -> pass (J1)
  • char::test_len_utf16: [missing] -> pass (J1)
  • collections::binary_heap::test_iter_rev_cloned_collect: [missing] -> pass (J1)
  • collections::hash::set::tests::const_with_hasher: [missing] -> pass (J1)
  • collections::linked_list::tests::test_ord_nan: [missing] -> pass (J1)
  • f64::test_next_up: [missing] -> pass (J1)
  • future::test_join_function_like_value_arg_semantics::join_lets_control_flow_effects_such_as_try_flow_through: [missing] -> pass (J1)
  • heap::alloc_system_overaligned_request: [missing] -> pass (J1)
  • io::buffered::tests::bench_buffered_reader_small_reads: [missing] -> pass (J1)
  • io::tests::take_size_hint: [missing] -> pass (J1)
  • mem::size_of_val_basic: [missing] -> pass (J1)
  • mpsc_sync::smoke_threads: [missing] -> pass (J1)
  • num::int_log::ilog2_of_0_panic: [missing] -> pass (J1)
  • num::test_try_i8i8: [missing] -> pass (J1)
  • num::test_try_u32u64: [missing] -> pass (J1)
  • num::u128::test_checked_next_multiple_of: [missing] -> pass (J1)
  • num::u32::test_midpoint: [missing] -> pass (J1)
  • num::u32::test_num: [missing] -> pass (J1)
  • once_lock::sync_once_cell_drop_empty: [missing] -> pass (J1)
  • str::const_str_ptr: [missing] -> pass (J1)
  • str::pattern::str_searcher_empty_needle_ascii_haystack::bwd: [missing] -> pass (J1)
  • str::test_replace_2a: [missing] -> pass (J1)
  • vec::test_vec_dedup_one: [missing] -> pass (J1)
  • vec_deque::test_rotate_right_random: [missing] -> pass (J1)
  • ascii::bench_ascii_escape_display_no_escape: [missing] -> pass (J2)
  • btree::set::intersection_10k_pos_vs_100_neg: [missing] -> pass (J2)
  • fs::tests::links_work: [missing] -> pass (J2)
  • num::dec2flt::bench_huge_int: [missing] -> pass (J2)
  • sort::tests::stable::correct_1k_descending: [missing] -> pass (J2)
  • sort::tests::unstable::deterministic_i32_descending: [missing] -> pass (J2)
  • sort::tests::unstable::stability_i32_descending: [missing] -> pass (J2)
  • str::char_count::ru_tiny::case01_filter_count_cont_bytes: [missing] -> pass (J2)
  • str::rfind_underscore_char::short_pile_of_poo: [missing] -> pass (J2)
  • vec::bench_clone_from_01_0100_0100: [missing] -> pass (J2)
  • vec::bench_from_iter_0000: [missing] -> pass (J2)
  • sort::tests::stable::correct_u64_saw_mixed: [missing] -> ignore (J3)
  • sort::tests::stable::panic_retain_orig_set_cell_i32_ascending: [missing] -> ignore (J3)
  • sort::tests::unstable::correct_i32_all_equal: [missing] -> ignore (J3)
  • sort::tests::unstable::correct_u64_ascending: [missing] -> ignore (J3)

Stage 2

  • errors::verify_builtin_macros_asm_pure_no_output_68: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_incorrect_cgu_reuse_type_1: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_invalid_monomorphization_second_argument_length_103: pass -> [missing] (J0)
  • errors::verify_metadata_global_alloc_required_50: pass -> [missing] (J0)
  • errors::verify_monomorphize_abi_error_unsupported_vector_type_9: pass -> [missing] (J0)
  • errors::verify_passes_layout_of_119: pass -> [missing] (J0)
  • html::markdown::tests::test_lang_string_parse: pass -> [missing] (J0)
  • lints::verify_lint_builtin_decl_unsafe_method_20: pass -> [missing] (J0)
  • lints::verify_lint_enum_intrinsics_mem_discriminant_40: pass -> [missing] (J0)
  • lints::verify_lint_incomplete_include_114: pass -> [missing] (J0)
  • spec::tests::armv4t_unknown_linux_gnueabi: pass -> [missing] (J0)
  • spec::tests::armv8r_none_eabihf: pass -> [missing] (J0)
  • spec::tests::x86_64_unknown_linux_none: pass -> [missing] (J0)
  • collections::btree::map::tests::test_try_insert: pass -> [missing] (J1)
  • collections::hash::set::tests::test_drain: pass -> [missing] (J1)
  • collections::vec_deque::tests::test_extend_basic: pass -> [missing] (J1)
  • f64::test_log2: pass -> [missing] (J1)
  • io::stdio::tests::test_lock_stderr: pass -> [missing] (J1)
  • io::tests::io_slice_into_slice: pass -> [missing] (J1)
  • mpmc::test_recv_into_iter_owned: pass -> [missing] (J1)
  • mpsc::oneshot_single_thread_try_recv_closed: pass -> [missing] (J1)
  • num::i128::test_leading_trailing_ones: pass -> [missing] (J1)
  • num::i8::test_div_ceil: pass -> [missing] (J1)
  • num::ops::test_sub_assign_defined: pass -> [missing] (J1)
  • num::test_try_i128u64: pass -> [missing] (J1)
  • num::test_try_u8i64: pass -> [missing] (J1)
  • num::u32::test_overflows: pass -> [missing] (J1)
  • slice::test_iterator_count: pass -> [missing] (J1)
  • sort::tests::stable::correct_1k_random_z1: pass -> [missing] (J1)
  • sort::tests::stable::correct_dyn_val_random_z1: pass -> [missing] (J1)
  • str::test_trim_matches: pass -> [missing] (J1)
  • sys_common::wtf8::tests::wtf8_make_ascii_lowercase: pass -> [missing] (J1)
  • sys_common::wtf8::tests::wtf8buf_push_wtf8: pass -> [missing] (J1)
  • vec::test_splice_out_of_bounds: pass -> [missing] (J1)
  • btree::map::clone_slim_10k_and_clear: pass -> [missing] (J2)
  • num::int_sqrt::u64_sqrt_random_small: pass -> [missing] (J2)
  • os::unix::net::tests::test_unix_datagram_peek_from: pass -> [missing] (J2)
  • slice::swap_with_slice_usize_3000: pass -> [missing] (J2)
  • sort::tests::stable::panic_retain_orig_set_string_ascending: pass -> [missing] (J2)
  • sort::tests::stable::panic_retain_orig_set_string_random_d20: pass -> [missing] (J2)
  • str::char_count::en_large::case00_libcore: pass -> [missing] (J2)
  • str::char_count::en_tiny::case02_iter_increment: pass -> [missing] (J2)
  • str::split_ad_str::short_pile_of_poo: pass -> [missing] (J2)
  • vec::bench_in_place_xu32_1000_i0: pass -> [missing] (J2)
  • sort::tests::unstable::panic_retain_orig_set_i32_random_d20: ignore -> [missing] (J3)
  • sort::tests::unstable::stability_string_random: ignore -> [missing] (J3)

(and 16404 additional test diffs)

Additionally, 16496 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: aarch64-apple, x86_64-apple-1
  • J1: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
  • J2: aarch64-apple, test-various, x86_64-apple-1
  • J3: x86_64-gnu-aux

Job duration changes

  1. x86_64-apple-2: 1614.8s -> 4755.2s (194.5%)
  2. test-various: 2304.2s -> 4301.5s (86.7%)
  3. dist-aarch64-linux: 5302.7s -> 8204.0s (54.7%)
  4. x86_64-apple-1: 6425.5s -> 9927.1s (54.5%)
  5. x86_64-gnu-aux: 4242.7s -> 6128.0s (44.4%)
  6. aarch64-apple: 2930.5s -> 3676.7s (25.5%)
  7. dist-armv7-linux: 5165.9s -> 5520.9s (6.9%)
  8. dist-x86_64-netbsd: 5018.7s -> 5291.3s (5.4%)
  9. dist-i686-mingw: 7899.9s -> 8230.2s (4.2%)
  10. x86_64-msvc-ext2: 5707.2s -> 5941.3s (4.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#139494 Restrict some queries by def-kind more 25c4fb7f12eed0e87d0253c0fa9fe5e231ce2138 (link)
#139496 Revert r-a changes of #139455 e1ec4699d26344848e75edd31eb76c994e2e8566 (link)
#139506 add missing word in doc comment (part 2) 549dcdff107df9480d4f0c941259d5fa1311985f (link)
#139515 Improve presentation of closure signature mismatch from `Fn… fe4550f06afb8cfc277a9812af4dd8331f7a2d13 (link)
#139520 compiletest maintenance: sort deps and drop dep on anyhow 695cc1b5f31f014696fe1c0621aa10d920c03110 (link)
#139523 Rustc dev guide subtree update 604f388fc1c2b70b13c669d636e1aaa73d791566 (link)
#139526 Fix deprecation note for std::intrinsics 32da310295d42baa92c9c4d6593082e57ebf90a2 (link)
#139528 compiletest: Remove the --logfile flag c2a8904e79641018318ade3df0edc90783ffbee8 (link)
#139541 Instantiate higher-ranked transmute goal w/ placeholders be… eb7fad0b94e2d8e6b22b687416fef50ebf87131a (link)
#139547 Update library tracking issue template to set S-tracking-un… b62662a6c577763549bd9a7c95935fa0416e186b (link)

previous master: c1b8b7e86f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (97c966b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-1.6%, -0.1%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.1%, secondary 4.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
4.7% [4.7%, 4.7%] 1
Improvements ✅
(primary)
-2.7% [-3.1%, -2.3%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-3.1%, 2.2%] 3

Cycles

Results (primary -1.0%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.154s -> 778.182s (-0.25%)
Artifact size: 366.11 MiB -> 366.15 MiB (0.01%)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#139494 (Restrict some queries by def-kind more)
 - rust-lang#139496 (Revert r-a changes of rust-lang#139455)
 - rust-lang#139506 (add missing word in doc comment (part 2))
 - rust-lang#139515 (Improve presentation of closure signature mismatch from `Fn` trait goal)
 - rust-lang#139520 (compiletest maintenance: sort deps and drop dep on `anyhow`)
 - rust-lang#139523 (Rustc dev guide subtree update)
 - rust-lang#139526 (Fix deprecation note for std::intrinsics)
 - rust-lang#139528 (compiletest: Remove the `--logfile` flag)
 - rust-lang#139541 (Instantiate higher-ranked transmute goal w/ placeholders before emitting sub-obligations)
 - rust-lang#139547 (Update library tracking issue template to set S-tracking-unimplemented)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc CI-spurious-fail-mingw CI spurious failure: target env mingw merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.