Rollup of 10 pull requests #139552
Merged
Rollup of 10 pull requests #139552
+207
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test directive can appear anywhere in the file
add some links about the rustdoc-gui test suite
Update book.toml fix the authors field
Fix deadlink in libs-and-metadata.md
Rustc pull update
…ocks" This reverts commit 51b51b5.
Currently `compiletest` panics all over the place but doesn't really use `anyhow` anyway. I'd like to introduce some more principled error handling and disciplined diagnostic reporting in the near future.
Also checked the rest of the mentions of std::mem in the changed file and they look good to me.
This flag is deprecated in libtest, and there's no evidence in-tree of this flag actually being passed to compiletest. (For detailed information about test results, bootstrap parses JSON output from compiletest instead.)
This will help people notice the `S-tracking-*` labels, and if the tracking issue *is* implemented, they can change the label.
…r=oli-obk Restrict some queries by def-kind more Random cleanup. I prefer things to assert more so as to catch bugs :) r? oli-obk
…kril Revert r-a changes of rust-lang#139455 I discovered rust-lang#132735 (comment) that I might have done too much in rust-lang#132735 by also removing support in r-a. So this reverts the commit with the changes to r-a. r? RalfJung
add missing word in doc comment (part 2)
Improve presentation of closure signature mismatch from `Fn` trait goal Flip the order of "expected" and "found" since that wasn't correct. Don't present the arguments as a tuple, since it leaves a trailing comma. Instead, just use `fn(arg, arg)`. Finally, be better with binders since we were just skipping binders. r? oli-obk or reassign
…, r=lqd compiletest maintenance: sort deps and drop dep on `anyhow` Two changes: 1. Sort compiletest deps alphabetically because it was annoying me (harder to quickly glance what deps compiletest is using). 2. Drop dependency on `anyhow`. There's only one usage of `anyhow`, which is for `with_context` on sth that would immediately panic anyway.
Rustc dev guide subtree update r? `@jieyouxu`
rustbot
added
T-libs
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2025
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#139494 (Restrict some queries by def-kind more) - rust-lang#139496 (Revert r-a changes of rust-lang#139455) - rust-lang#139506 (add missing word in doc comment (part 2)) - rust-lang#139515 (Improve presentation of closure signature mismatch from `Fn` trait goal) - rust-lang#139520 (compiletest maintenance: sort deps and drop dep on `anyhow`) - rust-lang#139523 (Rustc dev guide subtree update) - rust-lang#139526 (Fix deprecation note for std::intrinsics) - rust-lang#139528 (compiletest: Remove the `--logfile` flag) - rust-lang#139541 (Instantiate higher-ranked transmute goal w/ placeholders before emitting sub-obligations) - rust-lang#139547 (Update library tracking issue template to set S-tracking-unimplemented) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Spurious perm error. |
bors
added
S-waiting-on-bors
jieyouxu
added
S-waiting-on-review
|
@bors p=6 |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c1b8b7e (parent) -> 97c966b (this PR) Test differencesShow 33000 test diffsStage 1
Stage 2
(and 16404 additional test diffs) Additionally, 16496 doctest diffs were found. These are ignored, as they are noisy. Job group index
Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: c1b8b7e86f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (97c966b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.1%, secondary 4.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -1.0%, secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 780.154s -> 778.182s (-0.25%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
extern "rust-intrinsic"blocks #139455)Fntrait goal #139515 (Improve presentation of closure signature mismatch fromFntrait goal)anyhow#139520 (compiletest maintenance: sort deps and drop dep onanyhow)--logfileflag #139528 (compiletest: Remove the--logfileflag)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup