-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Removed outdated ui test suite README, give reasons for disabled tests #139705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should consolidate our test suite docs in rustc-dev-guide, and this README is very outdated.
Note that compiletest will also ignore any directory containing a file named rust/src/tools/compiletest/src/lib.rs Lines 762 to 765 in 1bc5618
|
I think it's fine to mark precondition-checks files individually as unimplemented, b/c they make become implemented separately. Surprised we even have @bors r+ rollup |
Oh I should've mentioned, I saw some of the precondition-check tests under the same dir active, which is why I didn't ignore that whole directory. (I thought the ignore dir comment was a general remark.) See https://github.com/rust-lang/rust/tree/master/tests%2Fui%2Fprecondition-checks, only these few precondition-check tests (that is, the ones changed in this PR) aren't implemented yet. |
…enton Rollup of 8 pull requests Successful merges: - rust-lang#139163 (indirect-const-stabilize the `exact_div` intrinsic) - rust-lang#139276 (Revert "Disable `f16` on Aarch64 without `neon`") - rust-lang#139315 (Switch `time` to `jiff` for time formatting in ICE dumps) - rust-lang#139382 (Update windows-bindgen to 0.61.0) - rust-lang#139688 (rustdoc-search: add unbox flag to Result aliases) - rust-lang#139701 (docs: clarify uint exponent for `is_power_of_two`) - rust-lang#139705 (Removed outdated ui test suite README, give reasons for disabled tests) - rust-lang#139713 (Fix typo in documentation) r? `@ghost` `@rustbot` modify labels: rollup
…enton Rollup of 8 pull requests Successful merges: - rust-lang#139163 (indirect-const-stabilize the `exact_div` intrinsic) - rust-lang#139276 (Revert "Disable `f16` on Aarch64 without `neon`") - rust-lang#139315 (Switch `time` to `jiff` for time formatting in ICE dumps) - rust-lang#139382 (Update windows-bindgen to 0.61.0) - rust-lang#139688 (rustdoc-search: add unbox flag to Result aliases) - rust-lang#139701 (docs: clarify uint exponent for `is_power_of_two`) - rust-lang#139705 (Removed outdated ui test suite README, give reasons for disabled tests) - rust-lang#139713 (Fix typo in documentation) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#139705 - jieyouxu:tests-precursor, r=compiler-errors Removed outdated ui test suite README, give reasons for disabled tests ### Changes - `tests/ui/README.md` is very outdated, test suite docs should consistently live in rustc-dev-guide. - Add reasons for `//@ ignore-test` tests that don't have one.[^query] This is a precursor change to make follow-up changes easier (possibly more specialized directives or converting some auxiliaries into the canonical `auxiliary/` form). [^query]: searched via `rg --no-ignore -F -e "ignore-test" tests/`.
Use `compiletest-ignore-dir` for bootstrap self-tests Follow-up to rust-lang#139705 and rust-lang#139740. I did another survey pass over `//@ ignore-test` under `tests/`, and this is the only 2 non-tests that should use `compiletest-ignore-dir`. r? `@Zalathar` (or compiler/bootstrap)
Use `compiletest-ignore-dir` for bootstrap self-tests Follow-up to rust-lang#139705 and rust-lang#139740. I did another survey pass over `//@ ignore-test` under `tests/`, and this is the only 2 non-tests that should use `compiletest-ignore-dir`. r? ``@Zalathar`` (or compiler/bootstrap)
Use `compiletest-ignore-dir` for bootstrap self-tests Follow-up to rust-lang#139705 and rust-lang#139740. I did another survey pass over `//@ ignore-test` under `tests/`, and this is the only 2 non-tests that should use `compiletest-ignore-dir`. r? ```@Zalathar``` (or compiler/bootstrap)
Rollup merge of rust-lang#139783 - jieyouxu:ignore-dir, r=Zalathar Use `compiletest-ignore-dir` for bootstrap self-tests Follow-up to rust-lang#139705 and rust-lang#139740. I did another survey pass over `//@ ignore-test` under `tests/`, and this is the only 2 non-tests that should use `compiletest-ignore-dir`. r? `@Zalathar` (or compiler/bootstrap)
Changes
tests/ui/README.md
is very outdated, test suite docs should consistently live in rustc-dev-guide.//@ ignore-test
tests that don't have one.1This is a precursor change to make follow-up changes easier (possibly more specialized directives or converting some auxiliaries into the canonical
auxiliary/
form).Footnotes
searched via
rg --no-ignore -F -e "ignore-test" tests/
. ↩