add CStr::display
#139994
Open
add CStr::display
#139994
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
16 tasks
|
Could you add a doc comments clarifying what this does for escaping? Since this requires FCP: |
rustbot
added
the
I-libs-api-nominated
tgross35
added
needs-fcp
bjorn3
reviewed
Apr 18, 2025
tamird
commented
Apr 18, 2025
This was referenced Apr 19, 2025
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 21, 2025
{B,C}Str: minor cleanup
(hopefully) uncontroversial bits extracted from rust-lang#139994.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2025
Rollup merge of rust-lang#140118 - tamird:cstr-cleanup, r=joboet {B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.
|
☔ The latest upstream changes (presumably #140127) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
added
the
I-libs-api-nominated
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 23, 2025
{B,C}Str: minor cleanup
(hopefully) uncontroversial bits extracted from rust-lang#139994.
|
In rust-lang/libs-team#550 the @rust-lang/libs-api team decided against implementing |
Amanieu
removed
the
I-libs-api-nominated
|
Shall I rework this? Can I use |
|
Yes, it's fine to rework this to return |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: rust-lang#139984.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation delegates to
<ByteStr as Display>::fmt.Link: rust-lang/libs-team#550
Link: #139984.
r? @BurntSushi
cc @Darksonn @tgross35 @ojeda @joshtriplett