-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Implement the internal feature cfg_target_has_reliable_f16_f128
#140323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ use super::write::WriteBackendMethods; | |
use crate::back::archive::ArArchiveBuilderBuilder; | ||
use crate::back::link::link_binary; | ||
use crate::back::write::TargetMachineFactoryFn; | ||
use crate::{CodegenResults, ModuleCodegen}; | ||
use crate::{CodegenResults, ModuleCodegen, TargetConfig}; | ||
|
||
pub trait BackendTypes { | ||
type Value: CodegenObject; | ||
|
@@ -50,8 +50,15 @@ pub trait CodegenBackend { | |
/// - The second is like the first, but also includes unstable features. | ||
/// | ||
/// RUSTC_SPECIFIC_FEATURES should be skipped here, those are handled outside codegen. | ||
fn target_features_cfg(&self, _sess: &Session) -> (Vec<Symbol>, Vec<Symbol>) { | ||
(vec![], vec![]) | ||
fn target_config(&self, _sess: &Session) -> TargetConfig { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Documentation of this function is outdated. Also, why are the defaults There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the documentation catch. Since the rollup is already testing, I'll fix this in a follow up.
|
||
TargetConfig { | ||
target_features: vec![], | ||
unstable_target_features: vec![], | ||
has_reliable_f16: true, | ||
has_reliable_f16_math: true, | ||
has_reliable_f128: true, | ||
has_reliable_f128_math: true, | ||
} | ||
} | ||
|
||
fn print_passes(&self) {} | ||
|
Uh oh!
There was an error while loading. Please reload this page.