-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: add stability and source links to the methods; w/ style tweaks #14042
Conversation
It looks like some of the bullets don't have titles (such as |
The implementation is fine by me. The bullets look like they're a little small, but once you see them everywhere they may be pretty obvious. The color scheme is also helpful I think. |
@alexcrichton Right, updated. |
Repushed latest commit without changes to see if Travis triggers. Seems like it doesn't. |
(needs a rebase) |
…ng#12932. this change made most functions that render the methods to require the render `Context`, so they are now made into `Context` methods. Conflicts: src/librustdoc/html/markdown.rs src/librustdoc/html/render.rs src/librustdoc/html/static/main.css Conflicts: src/librustdoc/html/render.rs
this makes a source link much more visible (and link-like), and makes a stability index more consistent for the top-level headings and the method signature. this should be better than nothing, but further adjustments and/or redesigns are welcomed. Conflicts: src/librustdoc/html/static/main.css
The first commit was a pain to work with but, rebased. |
After thinking a little bit about this, what would you think about removing the bullets and making the left-hand side a colored bar going up an down the page? That way it may be a little clearer and all of the stability levels will line up. It may also be nice to have the stability levels extend to the height of the entire method block (the whole function). Does that make sense? |
FWIW, I think the mouse-over only text for the stability attributes is hard to find, and is essentially unusable on a touchscreen. |
I think the bullets are fine for the more stable levels, but experimental and deprecated items should have more noticeable markers, I could see myself just looking over them as "just more bullets". So the experimental and deprecated levels should get a rectangular tag instead. Given that, I think the bullets for |
I will work on it this week-end. @lifthrasiir: do you know why I see |
@adrientetar I think some merged changes after the initial PR had inserted a reference to the context. If they are present in the |
Closing due to inactivity, but feel free to reopen with a rebase! |
I will revive this when I've got some time. |
internal: Add a manual section for Flatpak Fixes rust-lang#14042
[src]
for the source links, don't show them on methods until (method+description) is hoveredExample: http://adrientetar.legtux.org/cached/rust-docs/foo.htm
cc @lifthrasiir. Closes #13802, which fixes #12932.
r? @alexcrichton