-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 11 pull requests #140503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #140503
Conversation
Most notably, the `FIXME` for suboptimal printing of `use` groups in `tests/ui/macros/stringify.rs` is fixed. And all other test output changes result in pretty printed output being closer to the original formatting in the source code.
…homcc Remove backticks from `ShouldPanic::YesWithMessage`'s `TrFailedMsg` More legible imo ```rs #[test] #[should_panic = "love"] fn foo() { assert!(1 == 2); } ``` Before: ``` note: panic did not contain expected string panic message: `"assertion failed: 1 == 2"`, expected substring: `"love"` ``` After: ``` note: panic did not contain expected string panic message: "assertion failed: 1 == 2" expected substring: "love" ``` Also removed the comma as `assert_eq!` / `assert_ne!` don't use one. ``@rustbot`` label +A-libtest
…agisa uses_power_alignment: wording tweaks Slightly improves the wording introduced with rust-lang#135552.
…provenance-139008, r=RalfJung mention provenance in the pointer::wrapping_offset docs fixes rust-lang#139008
…etrochenkov Improve pretty-printing of braces r? ````@petrochenkov````
…=compiler-errors rm `TypeVistable` impls for `Canonical` similar to `EarlyBinder`, you generally do not want to fold a canonical value directly without first instantiating it. In places where you do want to look into the `Canonical`, it's likely better to do so manually. r? ```@compiler-errors```
…s-msa, r=jieyouxu enable msa feature for mips in codegen tests Fix codegen unit tests for mips by enabling the msa target feature.
…s, r=Kobzol Add `rust.debug-assertions-tools` option Before this PR, the two only options to configure the presence of debug assertions were the `rust.debug-assertions` and `rust.debug-assertions-std` options. The former applied to everything, and the latter allowed to override the setting just for the standard library. This combination of settings doesn't allow to enable debug assertions for the std and the compiler but not tools. Some tools (like Cargo) are not really meant to be executed with debug assertions enabled, and in Ferrocene we hit some debug assertions in it that are exclusively meant for its test suite. We'd thus like to enable debug assertions everywhere but in tools. This PR adds a `rust.debug-assertions-tools` setting that does exactly this.
…et, r=oli-obk miri: algebraic intrinsics: bring back float non-determinism Fixes rust-lang/miri#4289 Cc ```@bjoernager``` r? ```@oli-obk```
…1-dead Treat ManuallyDrop as ~const Destruct cc rust-lang#133214 (comment) r? ```@compiler-errors``` cc ```@fee1-dead```
chore: fix some tests
…errors Rename `rustc_query_append!` to `rustc_with_all_queries!` Whenever I'm trying to make sense of the query system internals, I always get tripped up on this unhelpfully-named macro. The fact that it's a higher-order proc macro is already mind-melting enough on its own. This new name, `rustc_with_all_queries!`, forms a much more intuitive combination with the helper macros that it invokes. And only one of the call sites was even making use of the “append” part of its old name. This PR also reformats the parameters matched by the helper macros, to make the actual argument syntax a bit easier to see. --- Renaming and reformatting only; no functional changes.
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d2eadb7 (parent) -> 7188f45 (this PR) Test differencesShow 202 test diffsStage 1
Stage 2
Additionally, 186 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7188f453111502962326022740e2657fce0a6939 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
📌 Perf builds for each rolled up PR:
previous master: d2eadb7a94 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (7188f45): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 770.233s -> 770.688s (0.06%) |
Successful merges:
ShouldPanic::YesWithMessage
'sTrFailedMsg
#136160 (Remove backticks fromShouldPanic::YesWithMessage
'sTrFailedMsg
)TypeVistable
impls forCanonical
#140404 (rmTypeVistable
impls forCanonical
)rust.debug-assertions-tools
option #140438 (Addrust.debug-assertions-tools
option)rustc_query_append!
torustc_with_all_queries!
#140448 (Renamerustc_query_append!
torustc_with_all_queries!
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup