Skip to content

trait selection: check & before suggest remove deref #140736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

trait selection: check & before suggest remove deref #140736

merged 2 commits into from
May 8, 2025

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented May 7, 2025

FIxes #140166

r? compiler

@xizheyin
Add ui test suggest-remove-deref-issue-140166
f46806f 
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2025
@xizheyin xizheyin force-pushed the issue-140166 branch 2 times, most recently from 29a4cff to 8a5cba1 Compare May 7, 2025 14:34
xizheyin
xizheyin commented May 7, 2025
View reviewed changes
Copy link
Contributor Author

@xizheyin xizheyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot ready

I comment on the code. A little difference will make a world of difference, it's really subtle.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2025
@xizheyin
Check & before suggest remove deref when trait_selection
bd88f3e 
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@xizheyin
Copy link
Contributor Author

xizheyin commented May 7, 2025

Thanks for your suggestions! The current changes seem minimal.

Waiting for CI passing, but it shouldn't be a problem because I tested it locally.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2025
@xizheyin
Copy link
Contributor Author

xizheyin commented May 7, 2025

CI has passed. :)

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 8, 2025

📌 Commit bd88f3e has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#140736 - xizheyin:issue-140166, r=petrochenkov
d2acdb1 
trait selection: check `&` before suggest remove deref

FIxes rust-lang#140166

r? compiler
@matthiaskrgr matthiaskrgr mentioned this pull request May 8, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2025
@bors
Auto merge of rust-lang#140788 - matthiaskrgr:rollup-rgsbl0h, r=matth…
da378d7 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#140716 (Improve `-Zremap-path-scope` tests with dependency)
 - rust-lang#140732 (make it possible to run in-tree rustfmt with `x run rustfmt`)
 - rust-lang#140736 (trait selection: check `&` before suggest remove deref)
 - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
 - rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
 - rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
 - rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request May 8, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2025
@bors
Auto merge of rust-lang#140797 - matthiaskrgr:rollup-3km95qh, r=matth…
fe348cd 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#140736 (trait selection: check `&` before suggest remove deref)
 - rust-lang#140755 ([win][arm64] Disable various DebugInfo tests that don't work on Arm64 Windows)
 - rust-lang#140756 ([arm64] Pointer auth test should link with C static library statically)
 - rust-lang#140758 ([win][arm64] Disable MSVC Linker 'Arm Hazard' warning)
 - rust-lang#140759 ([win][arm64] Disable std::fs tests that require symlinks)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4ed1318 into rust-lang:master May 8, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 8, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2025
@rust-timer
Unrolled build for rust-lang#140736
60ec3b7 
Rollup merge of rust-lang#140736 - xizheyin:issue-140166, r=petrochenkov

trait selection: check `&` before suggest remove deref

FIxes rust-lang#140166

r? compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov approved these changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

Incorrect '&'-reference removal
4 participants
@xizheyin @petrochenkov @bors @rustbot