Skip to content

Bump version number to 1.89.0 #140839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented May 9, 2025

Part of the release process. This PR must not be rolled up.

Closes #129461.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels May 9, 2025
@pietroalbini
Copy link
Member Author

@bors r+ rollup=never p=100

Putting a high priority for this as I'd love to do more release steps during the weekend, since next week a lot of the release team (me included!) will be at RustWeek.

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit 767d64d has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
@rust-log-analyzer

This comment has been minimized.

@jieyouxu
Copy link
Member

jieyouxu commented May 9, 2025

Oh hey the time bomb exploded (#133245)

@jieyouxu
Copy link
Member

jieyouxu commented May 9, 2025

@bors r- (time bomb for the time diagnostic hack)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2025
Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu"

This reverts commit 26f75a6, reversing
changes made to 2572e0e.

Imports are modified to fix merge conflicts and remove unused ones.
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

Some changes occurred in need_type_info.rs

cc @lcnr

@pietroalbini
Copy link
Member Author

Fixed the time bomb.

@bors r+ p=100 rollup=never

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit 7dae318 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 9, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
…roalbini

Bump version number to 1.89.0

Part of the release process. This PR must not be rolled up.

Closes rust-lang#129461.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 9, 2025

⌛ Testing commit 7dae318 with merge 9d891b4...

@bors
Copy link
Collaborator

bors commented May 9, 2025

⌛ Testing commit 7dae318 with merge a9d24f2...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
…roalbini

Bump version number to 1.89.0

Part of the release process. This PR must not be rolled up.

Closes rust-lang#129461.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 9, 2025

⌛ Testing commit 7dae318 with merge dcecb99...

@bors
Copy link
Collaborator

bors commented May 9, 2025

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing dcecb99 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2025
@bors bors merged commit dcecb99 into rust-lang:master May 9, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 9, 2025
@pietroalbini pietroalbini deleted the pa-version-bump branch May 9, 2025 15:27
Copy link

github-actions bot commented May 9, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing da1e442 (parent) -> dcecb99 (this PR)

Test differences

Show 3 test diffs

Stage 1

  • [ui] tests/ui/inference/detect-old-time-version-format_description-parse.rs: pass -> [missing] (J0)

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J1)
  • [ui] tests/ui/inference/detect-old-time-version-format_description-parse.rs: pass -> [missing] (J2)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard dcecb99176edf2eec51613730937d21cdd5c8f6e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2643.9s -> 4313.2s (63.1%)
  2. dist-apple-various: 9408.9s -> 5431.7s (-42.3%)
  3. mingw-check: 1289.9s -> 1821.3s (41.2%)
  4. test-various: 4196.6s -> 5808.4s (38.4%)
  5. armhf-gnu: 4436.5s -> 6040.2s (36.1%)
  6. x86_64-gnu: 6344.5s -> 8514.3s (34.2%)
  7. arm-android: 5323.0s -> 7079.0s (33.0%)
  8. x86_64-gnu-stable: 6531.0s -> 8483.6s (29.9%)
  9. x86_64-gnu-nopt: 5774.7s -> 7367.5s (27.6%)
  10. x86_64-gnu-aux: 6064.5s -> 7670.8s (26.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dcecb99): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Max RSS (memory usage)

Results (primary 0.2%, secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.4%, 2.1%] 9
Regressions ❌
(secondary)
3.3% [1.1%, 5.6%] 2
Improvements ✅
(primary)
-1.4% [-2.9%, -0.6%] 4
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 0.2% [-2.9%, 2.1%] 13

Cycles

Results (primary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.4%, 0.8%] 10
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [0.4%, 0.8%] 10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.723s -> 773.559s (0.24%)
Artifact size: 365.67 MiB -> 365.71 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove time-boxed time inference regression mitigation note
6 participants