-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Bump version number to 1.89.0 #140839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version number to 1.89.0 #140839
Conversation
@bors r+ rollup=never p=100 Putting a high priority for this as I'd love to do more release steps during the weekend, since next week a lot of the release team (me included!) will be at RustWeek. |
This comment has been minimized.
This comment has been minimized.
Oh hey the time bomb exploded (#133245) |
@bors r- (time bomb for the |
Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu" This reverts commit 26f75a6, reversing changes made to 2572e0e. Imports are modified to fix merge conflicts and remove unused ones.
Some changes occurred in need_type_info.rs cc @lcnr |
Fixed the time bomb. @bors r+ p=100 rollup=never |
…roalbini Bump version number to 1.89.0 Part of the release process. This PR must not be rolled up. Closes rust-lang#129461. r? `@ghost`
…roalbini Bump version number to 1.89.0 Part of the release process. This PR must not be rolled up. Closes rust-lang#129461. r? `@ghost`
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing da1e442 (parent) -> dcecb99 (this PR) Test differencesShow 3 test diffsStage 1
Stage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard dcecb99176edf2eec51613730937d21cdd5c8f6e --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (dcecb99): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 0.2%, secondary 1.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.723s -> 773.559s (0.24%) |
Part of the release process. This PR must not be rolled up.
Closes #129461.
r? @ghost