Fix broken-pipe-no-ice run-make test for rpath-less builds
#140843
Merged
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases, the test may need access to the underlying `std::process::Command` (e.g. for non-trivial process spawning). Co-authored-by: Jesus Checa Hidalgo <jchecahi@redhat.com>
Where host compiler runtime libs are properly configured, instead of raw `RUSTC`/`RUSTDOC` commands. Co-authored-by: Jesus Checa Hidalgo <jchecahi@redhat.com>
rustbot
added
A-run-make
Kobzol
reviewed
May 9, 2025
|
Yeah I considered those options, but it seems really rare to need to implement those.
|
|
Waiting a bit to hear back from @jchecahi in case this isn't sufficient for them. Locally, the test passes for me when I set |
|
@jieyouxu yes, this approach fixes the test in my setup too. Thanks for looking into this! |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 9, 2025
Fix `broken-pipe-no-ice` run-make test for rpath-less builds The `broken-pipe-no-ice` run-make test currently fails on rpath-less builds, because host compiler runtime libs are not configured for raw std command usages. This PR is an alternative approach to rust-lang#140744. However, instead of duplicating `run_make_support::util::set_host_compiler_dylib_path` logic, we instead support "ejecting" the "configured" underlying std `Command` from `bare_rustc()` and `rustdoc()`, where host compiler runtime libs are already set. cc ``@jchecahi`` r? ``@Kobzol``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#139863 (rustdoc: Replace unstable flag `--doctest-compilation-args` with a simpler one: `--doctest-build-arg`) - rust-lang#140815 (also export metrics from librustdoc) - rust-lang#140819 (Add regression test for 125877) - rust-lang#140843 (Fix `broken-pipe-no-ice` run-make test for rpath-less builds) - rust-lang#140848 (Improved error message for top-level or-patterns) - rust-lang#140852 (Update the edition guide for let chains) - rust-lang#140864 (Last minute relnotes fix) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2025
Rollup merge of rust-lang#140843 - jieyouxu:broken-pipe, r=Kobzol Fix `broken-pipe-no-ice` run-make test for rpath-less builds The `broken-pipe-no-ice` run-make test currently fails on rpath-less builds, because host compiler runtime libs are not configured for raw std command usages. This PR is an alternative approach to rust-lang#140744. However, instead of duplicating `run_make_support::util::set_host_compiler_dylib_path` logic, we instead support "ejecting" the "configured" underlying std `Command` from `bare_rustc()` and `rustdoc()`, where host compiler runtime libs are already set. cc `@jchecahi` r? `@Kobzol`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
broken-pipe-no-icerun-make test currently fails on rpath-less builds, because host compiler runtime libs are not configured for raw std command usages.This PR is an alternative approach to #140744. However, instead of duplicating
run_make_support::util::set_host_compiler_dylib_pathlogic, we instead support "ejecting" the "configured" underlying stdCommandfrombare_rustc()andrustdoc(), where host compiler runtime libs are already set.cc @jchecahi
r? @Kobzol