-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add lint detects using #[export_name]
on generic functions
#140851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The job Click to see the possible cause of the failure (guessed by this bot)
|
pub EXPORT_NAME_GENERIC_ITEMS, | ||
Warn, | ||
"generic items must be mangled, export_name would avoid mangling" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually need to be a separate lint? #[unsafe(no_mangle)] fn foo()
is pretty much an alias for #[unsafe(export_name = "foo")] fn foo()
. So I think just adding #[export_name]
linting to the no_mangle_generic_items
lint without any renaming would be fine.
Fixes #140742