Skip to content

Conversation

Dietr1ch
Copy link
Contributor

This implements #140881

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 10, 2025
@rust-log-analyzer

This comment has been minimized.

@Dietr1ch Dietr1ch force-pushed the dev/duration_constructors_lite branch from f2ef49d to 8807aa0 Compare May 10, 2025 01:06
@rust-log-analyzer

This comment has been minimized.

@Dietr1ch Dietr1ch force-pushed the dev/duration_constructors_lite branch from 8807aa0 to ed799c2 Compare May 10, 2025 02:52
@fmease
Copy link
Member

fmease commented May 10, 2025

r? BurntSushi (#120301)

@BurntSushi
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 10, 2025

📌 Commit ed799c2 has been approved by BurntSushi

It is now in the queue for this repository.

@BurntSushi
Copy link
Member

Thanks!

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations)
 - rust-lang#140795 (Prefer to suggest stable candidates rather than unstable ones)
 - rust-lang#140865 (Make t letter looks like lowercase rather than uppercase)
 - rust-lang#140878 (Two expand-related cleanups)
 - rust-lang#140882 (Split duration_constructors to get non-controversial constructors out)
 - rust-lang#140886 (Update deps of bootstrap for Cygwin)
 - rust-lang#140903 (test intrinsic fallback bodies with Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e5835d5 into rust-lang:master May 11, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2025
Rollup merge of rust-lang#140882 - Dietr1ch:dev/duration_constructors_lite, r=BurntSushi

Split duration_constructors to get non-controversial constructors out

This implements rust-lang#140881
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request May 16, 2025
…_lite, r=BurntSushi

Split duration_constructors to get non-controversial constructors out

This implements rust-lang#140881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants