Skip to content

Update ctrlc, libloading and nix for rustc #140921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

Berrysoft
Copy link
Contributor

The main purpose is to update nix to 0.30.1. It adds support for cygwin.

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@Berrysoft Berrysoft force-pushed the update-rustc-lock branch from 12d69f9 to 7727a45 Compare May 11, 2025 09:56
@Berrysoft Berrysoft requested a review from jieyouxu May 11, 2025 09:57
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 13, 2025

📌 Commit 7727a45 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2025
@bors
Copy link
Collaborator

bors commented May 13, 2025

⌛ Testing commit 7727a45 with merge 414482f...

@bors
Copy link
Collaborator

bors commented May 13, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 414482f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2025
@bors bors merged commit 414482f into rust-lang:master May 13, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 13, 2025
@Berrysoft Berrysoft deleted the update-rustc-lock branch May 13, 2025 16:33
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4eca99a (parent) -> 414482f (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 414482f6a0d4e7290f614300581a0b55442552a3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4990.7s -> 6924.7s (38.8%)
  2. x86_64-apple-1: 7379.2s -> 9935.4s (34.6%)
  3. aarch64-apple: 4100.0s -> 5112.5s (24.7%)
  4. dist-ohos: 10766.4s -> 11763.3s (9.3%)
  5. mingw-check: 1242.1s -> 1356.1s (9.2%)
  6. i686-gnu-2: 7002.2s -> 6424.1s (-8.3%)
  7. dist-loongarch64-linux: 6443.7s -> 6877.3s (6.7%)
  8. dist-various-2: 3382.1s -> 3591.2s (6.2%)
  9. dist-x86_64-apple: 7120.5s -> 7551.1s (6.0%)
  10. x86_64-gnu-tools: 5954.6s -> 6311.3s (6.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Berrysoft Berrysoft mentioned this pull request May 13, 2025
8 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (414482f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.3% [-2.9%, -1.7%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-2.9%, 3.4%] 3

Cycles

Results (primary -1.2%, secondary 12.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
12.5% [2.4%, 17.8%] 7
Improvements ✅
(primary)
-1.2% [-1.2%, -1.2%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.795s -> 773.561s (0.23%)
Artifact size: 365.42 MiB -> 365.44 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants