Allow initializing logger with additional tracing Layer #140969
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I don't understand why the build fails, locally it works. The CI logs are 400MB, but here are the last few lines: |
|
Looks like something in this PR is causing a lot more debug messages to be emitted. Some of those debug messages use the "def path formatting" machinery, which is expensive and so there are safeguards that this machinery is only called when there are actual compilation errors to emit -- which isn't the case here, so we ultimately get an ICE. But the ICE isn't the actual problem, the actual problem is that debug tracing now seems to be enabled by default. |
RalfJung
reviewed
May 20, 2025
| @@ -104,7 +115,7 @@ pub fn init_logger(cfg: LoggerConfig) -> Result<(), Error> { | |||
| }; | |||
|
|
|||
| let mut layer = tracing_tree::HierarchicalLayer::default() | |||
| .with_writer(io::stderr) | |||
| .with_writer(io::stderr as fn() -> io::Stderr) | |||
There was a problem hiding this comment.
Why is there a fn ptr cast here now?
RalfJung
reviewed
May 20, 2025
| @@ -124,7 +135,8 @@ pub fn init_logger(cfg: LoggerConfig) -> Result<(), Error> { | |||
| Err(_) => {} // no wraptree | |||
| } | |||
|
|
|||
| let subscriber = tracing_subscriber::Registry::default().with(filter).with(layer); | |||
| let subscriber = | |||
| Registry::default().with(additional_tracing_layer).with(layer.with_filter(filter)); | |||
There was a problem hiding this comment.
This seems to change the way the filter is applied, which might explain the explosion of debug messages?
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions to the
rustc_logandrustc_driver_implcrates to allow initializing the logger with an additionaltracing_subscriber::Layer. This will be used in Miri to save trace events to file using e.g.tracing-chrome's ortracing-tracy'sLayers.Additional context on the choice of signature can be found in this Zulip thread.
I re-exported
tracing_subscriber::{Layer, Registry};fromrustc_logso thatrustc_driver_implcan use them in the function signature without depending ontracing_subscriberdirectly. I did this to avoid copy-pasting the dependency line with all of the enabled features from therustc_logto therustc_driver_impl's Cargo.toml, which would have possibly led to redundancies and inconsistencies.r? @RalfJung