Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a not found page #14126

Closed
wants to merge 1 commit into from
Closed

Conversation

richo
Copy link
Contributor

@richo richo commented May 12, 2014

I created a stub page for use when the docs 404.

Documentation on how to configure it is available here: http://aws.typepad.com/aws/2011/02/host-your-static-website-on-amazon-s3.html

@alexcrichton
Copy link
Member

It looks like the "error page" is in the same group as the "default index.html" page (see #11897). The default index page isn't working, so it seems like we should figure that out before moving ahead with this.

@alexcrichton
Copy link
Member

Hurray! We should be configured for this to work now.

This page may quickly find itself out of date, so it may be best to link to the one page which will never go away, www.rust-lang.org

Also, could you provide a sample rendering of the page?

@richo
Copy link
Contributor Author

richo commented May 13, 2014

Can absolutely link to the homepage.

I'll throw a rendered version up just as soon as I work out how and where.

@richo
Copy link
Contributor Author

richo commented May 13, 2014

Rendered version: http://richo.psych0tik.net/rust-docs/not_found.html

@thehydroimpulse
Copy link
Contributor

👍

@alexcrichton
Copy link
Member

I was thinking of removing the links to the documentation entirely (due to them possibly moving or becoming stale). Also, I think that all links will need to be absolute rather than relative because this will likely show up at any location on the site.

@richo
Copy link
Contributor Author

richo commented May 13, 2014

I'm pretty bullish on the doc links being kept (but I'll say upfront that this was 9 times out of 10 the result of me taking a guess on what the url for a given piece of docs that I wanted would be, and then getting it wrong). tl;dr I could take them or leave them, but for now I'm in favour of keeping them.

Absolute links I'm totally on board with, I'll push that now.

@richo
Copy link
Contributor Author

richo commented May 13, 2014

PR Updated. As an aside, no ssl cert? Can I sponsor this?

bors added a commit that referenced this pull request May 14, 2014
Closes #14184 (std: Move the owned module from core to std)
Closes #14183 (Allow blocks in const expressions)
Closes #14176 (Add tests for from_bits.)
Closes #14175 (Replaced ~T by Box<T> in manual)
Closes #14173 (Implements Default trait for BigInt and BigUint)
Closes #14171 (Fix #8391)
Closes #14159 (Clean up unicode code in libstd)
Closes #14126 (docs: Add a not found page)
Closes #14123 (add a line to the example to clarify semantics)
Closes #14106 (Pretty printer improvements)
Closes #14083 (rustllvm: Add LLVMRustArrayType)
Closes #13957 (io: Implement process wait timeouts)
@bors bors closed this in #14187 May 14, 2014
@alexcrichton
Copy link
Member

I'm not sure what our SSL situation is with rust-lang.org and friends. I'll see if I can figure that out tomorrow.

I'll also try to configure the not found page once the docs are uploaded tomorrow.

@richo
Copy link
Contributor Author

richo commented May 14, 2014

Thanks!

@alexcrichton
Copy link
Member

The not_found page was successfully delivered by S3, but the stylesheet links for the page are all relative instead of absolute, so none of the styling was picked up. I turned it off for now while this issue is dealt with.

@richo
Copy link
Contributor Author

richo commented May 14, 2014

Oh, so sorry about that. Pushing a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants