Skip to content

Bump rustc-perf and update PGO crates #141490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

compiler-errors
Copy link
Member

Updates rustc-perf to rust-lang/rustc-perf@8158f78, and updates the crates.

r? @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 24, 2025
bors added a commit that referenced this pull request May 24, 2025
Bump rustc-perf and update PGO crates

Updates rustc-perf to rust-lang/rustc-perf@8158f78, and updates the crates.

r? `@Kobzol`
@bors
Copy link
Collaborator

bors commented May 24, 2025

⌛ Trying commit d6c4ab8 with merge 4c4ffc4...

@bors
Copy link
Collaborator

bors commented May 24, 2025

☀️ Try build successful - checks-actions
Build commit: 4c4ffc4 (4c4ffc4ef78313dc32c25e917372a415ab446035)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4c4ffc4): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.3% [0.1%, 1.7%] 70
Regressions ❌
(secondary)
0.6% [0.1%, 2.2%] 89
Improvements ✅
(primary)
-0.4% [-1.9%, -0.1%] 84
Improvements ✅
(secondary)
-2.5% [-14.4%, -0.1%] 65
All ❌✅ (primary) -0.1% [-1.9%, 1.7%] 154

Max RSS (memory usage)

Results (primary -1.6%, secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.4% [1.1%, 1.7%] 2
Regressions ❌
(secondary)
4.9% [2.2%, 9.9%] 15
Improvements ✅
(primary)
-1.8% [-4.4%, -0.8%] 30
Improvements ✅
(secondary)
-4.5% [-7.8%, -1.1%] 25
All ❌✅ (primary) -1.6% [-4.4%, 1.7%] 32

Cycles

Results (primary -1.0%, secondary -8.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.1%, -0.9%] 2
Improvements ✅
(secondary)
-8.5% [-17.1%, -1.5%] 24
All ❌✅ (primary) -1.0% [-1.1%, -0.9%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.203s -> 774.104s (-0.27%)
Artifact size: 366.33 MiB -> 371.89 MiB (1.52%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 24, 2025
@compiler-errors
Copy link
Member Author

new solver perf improvements even without the crates being included is really funny 😆

i'm not missing anything here, right?

@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2025

Sorry, it's the same bug 🤦 Since some of the used benchmarks are prefixes of the new solver benchmarks, the new solver benchmarks are included even though we don't want them to be. I will fix it next week.

CC @nnethercote I think I will just change the behavior of --include to be exactly matching, I feel like we had enough trouble with the prefix/substring matching logic..

@lqd
Copy link
Member

lqd commented May 24, 2025

Can we --exclude-suffix new-solver maybe?

@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2025

But we actually want to add a few -new-solver benchmarks in a follow-up 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants