Skip to content

bootstrap: clippy: set TESTNAME based on given paths #141508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bootstrap: clippy: set TESTNAME based on given paths #141508

wants to merge 1 commit into from
+18 −1

Conversation

xtexx
Copy link
Contributor

@xtexx xtexx commented May 24, 2025

This addresses #104200 by setting the TESTNAME environment variable automatically based on the paths from run configs, marking a selected set of UI tests to be run.

Note that this does not filter out other unit tests using #[test].

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 24, 2025
@rustbot

This comment has been minimized.

Sign in to view
@xtexx
Copy link
Contributor Author

xtexx commented May 24, 2025

@rustbot label +A-clippy

@rustbot rustbot added the A-clippy Area: Clippy label May 24, 2025
onur-ozkan
onur-ozkan approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a minor note

@rustbot

This comment has been minimized.

Sign in to view
@xtexx
bootstrap: clippy: set TESTNAME based on given paths
4350fd1 
This addresses issue 104200 by setting the TESTNAME environment
variable automatically based on the paths from run configs,
marking a selected set of UI tests to be run.

Note that this does not filter out other unit tests using #[test].
@xtexx
Copy link
Contributor Author

xtexx commented May 25, 2025

@onur-ozkan Thanks for your quick review. I have removed that pattern matching and moved that line into the partially_test block.

@onur-ozkan
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented May 25, 2025

📌 Commit 4350fd1 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
A-clippy Area: Clippy A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xtexx @rustbot @onur-ozkan @bors