Draft: Make into_parts methods on Vec associated functions #141509
+29
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
rustbot
added
S-waiting-on-review
2 tasks
|
r? libs-api |
rustbot
added
the
T-libs-api
jieyouxu
added
the
needs-fcp
|
This PR is basically just to link to these patches from #65816 (comment). This will need to be rebased after #141219 is merged, and it might not be needed at all if open questions are resolved the other way in the main issue. The proper place for FCP is probably also the tracking issue, although I’m not that familiar with the process. |
This hopefully helps to catch cases where these arguments are accidentally swapped.
This is more consistent with `Box::into_raw()` and clears out potential confusion about whether the method acts on a vector or on a slice.
GoldsteinE
force-pushed
the
vec-into-raw-parts
branch
from
2bb1d8e to
efdd43d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(doesn’t need review for now, posted to accompany stabilization report)