Skip to content

Specify an associated type on AllocBytes #141513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Specify an associated type on AllocBytes #141513

wants to merge 1 commit into from
+88 −30

Conversation

nia-e
Copy link
Contributor

@nia-e nia-e commented May 24, 2025

Necessary for a better implementation of rust-lang/miri#4343. Also included here is the code from that PR, adapted to this new interface for the sake of example and so that CI can run on them; the Miri changes can be reverted and merged separately, though.

r? @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@nia-e nia-e marked this pull request as draft May 24, 2025 18:43
@nia-e
Copy link
Contributor Author

nia-e commented May 24, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@RalfJung
Copy link
Member

So you don't want a review yet? 🤔

RalfJung
RalfJung reviewed May 24, 2025
View reviewed changes
@nia-e
Copy link
Contributor Author

nia-e commented May 24, 2025

Feel free to go ahead, but it's not fully implemented. I realised right after opening this there was more to do, oopsie

@nia-e nia-e force-pushed the allocbytes-extend branch from 3dd9d4f to 15a3f38 Compare May 24, 2025 21:23
@nia-e
Copy link
Contributor Author

nia-e commented May 24, 2025

Ok! So I spent an hour or two panicking over some failing tests only to realise that they're failing on master, actually. Sobs. This was actually not far from ready from the start, oh well.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 24, 2025
@nia-e nia-e marked this pull request as ready for review May 24, 2025 21:28
@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nia-e nia-e force-pushed the allocbytes-extend branch from 15a3f38 to 3c71aef Compare May 24, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nia-e @rustbot @RalfJung @rust-log-analyzer