Rollup of 6 pull requests #141518

GuillaumeGomez · 2025-05-24T19:23:51Z

Successful merges:

Stabilize <[T; N]>::as_mut_slice as const #140066 (Stabilize <[T; N]>::as_mut_slice as const)
additional edge cases tests for path.rs 🧪 #141105 (additional edge cases tests for path.rs 🧪 )
Update askama to 0.14.0 #141487 (Update askama to 0.14.0)
Use C-string literals to reduce boilerplate #141498 (Use C-string literals to reduce boilerplate)
rename internal panicking::try to catch_unwind #141505 (rename internal panicking::try to catch_unwind)
Cleanup CodegenFnAttrFlags #141511 (Cleanup CodegenFnAttrFlags)

r? @ghost
@rustbot modify labels: rollup

Reduce boilerplate in doctests by replacing fallible function calls with literals.

- Rename `USED` to `USED_COMPILER` to better reflect its behavior. - Reorder some items to group the used and allocator flags together - Renumber them without gaps

…ce, r=jhpratt Stabilize `<[T; N]>::as_mut_slice` as `const` This is trivial and has no design questions. Tracked in rust-lang#133333. r? libs-api

…r=jhpratt additional edge cases tests for `path.rs` 🧪 This pull request adds a few new edge case tests to the `std::path` module. The new tests cover scenarios such as paths with only separators, non-ASCII and Unicode characters, embedded new lines, etc. Each new test is documented with some helpful in-line comments as well.

…triddle Update askama to `0.14.0` [Askama 0.14.0 release notes](https://github.com/askama-rs/askama/releases/tag/v0.14.0) Just one change needed for a filter in rustdoc. r? ```@notriddle```

Use C-string literals to reduce boilerplate Reduce boilerplate in doctests by replacing fallible function calls with literals.

rename internal panicking::try to catch_unwind The public function is called `catch_unwind`, the intrinsic at some point got renamed to `catch_unwind` -- there's no reason to have the internal implementation of this still be called `try`, so let's rename it to match the rest.

…iler-errors Cleanup CodegenFnAttrFlags - Rename `USED` to `USED_COMPILER` to better reflect its behavior. - Reorder some items to group the used and allocator flags together - Renumber them without gaps

GuillaumeGomez · 2025-05-24T19:24:02Z

@bors r+ p=5 rollup=never

bors · 2025-05-24T19:24:05Z

📌 Commit 7cd749d has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-05-24T21:00:14Z

⌛ Testing commit 7cd749d with merge 3d86494...

bors · 2025-05-25T00:11:56Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 3d86494 to master...

rust-timer · 2025-05-25T00:13:38Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#140066	Stabilize `<[T; N]>::as_mut_slice` as `const`	`95e8f09d304e6c229638f7d805cdfc009fd6de15` (link)
#141105	additional edge cases tests for `path.rs` 🧪	`9379c1ae15d41186f930239490b1d4c96d751d45` (link)
#141487	Update askama to `0.14.0`	`7aff891f3f2a97a2ea270df3f0e5d0c600162941` (link)
#141498	Use C-string literals to reduce boilerplate	`d7e2b8e078c2bf7656230d47032a7d137ab8c813` (link)
#141505	rename internal panicking::try to catch_unwind	`b06c43c8703312edbc110989b6480d8580bc41e2` (link)
#141511	Cleanup CodegenFnAttrFlags	`552fa28ec8e93dfd30cd4d71f1f71a783f06fc65` (link)

previous master: 5e16c66206

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-05-25T00:15:05Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5e16c66 (parent) -> 3d86494 (this PR)

Test differences

Show 26 test diffs

Stage 0

test_embedded_newline: [missing] -> pass (J0)
test_non_ascii_unicode: [missing] -> pass (J0)
test_only_separators: [missing] -> pass (J0)

Stage 1

test_embedded_newline: [missing] -> pass (J1)
test_non_ascii_unicode: [missing] -> pass (J1)
test_only_separators: [missing] -> pass (J1)

Additionally, 20 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3d86494a0d0131c32eb15e3a4b685707b9ff000d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 6837.1s -> 9079.7s (32.8%)
x86_64-apple-2: 4717.4s -> 5723.3s (21.3%)
dist-apple-various: 5838.1s -> 6780.8s (16.1%)
dist-x86_64-apple: 7607.0s -> 8504.5s (11.8%)
x86_64-mingw-2: 7709.8s -> 7062.6s (-8.4%)
mingw-check: 1259.2s -> 1170.8s (-7.0%)
dist-ohos-armv7: 4337.9s -> 4048.3s (-6.7%)
x86_64-gnu-debug: 5863.7s -> 6209.1s (5.9%)
aarch64-apple: 4197.9s -> 3986.9s (-5.0%)
dist-powerpc-linux: 5314.3s -> 5559.4s (4.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-25T02:32:30Z

Finished benchmarking commit (3d86494): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -1.2%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.893s -> 775.592s (-0.04%)
Artifact size: 366.32 MiB -> 366.33 MiB (0.01%)

thaliaarchi and others added 17 commits April 20, 2025 02:13

Stabilize <[T; N]>::as_mut_slice as const

38c5545

additional edge cases tests for path.rs

49658e6

remove test_embedded_null_byte() test for now

604f0e2

revert forward slash to backslash

1bc8535

remove extra tests that really might not be all that useful

4358a1c

Update askama version to 0.14.0 in librustdoc

f534733

Update askama version to 0.14.0 in generate-copyright tool

2885e55

Update askama version to 0.14.0 in citool

a643892

Use C-string literals to reduce boilerplate

7b5a079

Reduce boilerplate in doctests by replacing fallible function calls with literals.

rename internal panicking::try to catch_unwind

1827bc0

Cleanup CodegenFnAttrFlags

fa2bb59

- Rename `USED` to `USED_COMPILER` to better reflect its behavior. - Reorder some items to group the used and allocator flags together - Renumber them without gaps

Rollup merge of rust-lang#140066 - thaliaarchi:const-array-as-mut-sli…

07157b7

…ce, r=jhpratt Stabilize `<[T; N]>::as_mut_slice` as `const` This is trivial and has no design questions. Tracked in rust-lang#133333. r? libs-api

Rollup merge of rust-lang#141487 - GuillaumeGomez:update-askama, r=no…

0846035

…triddle Update askama to `0.14.0` [Askama 0.14.0 release notes](https://github.com/askama-rs/askama/releases/tag/v0.14.0) Just one change needed for a filter in rustdoc. r? ```@notriddle```

Rollup merge of rust-lang#141498 - tamird:cstr-example-noise, r=jhpratt

c4a313a

Use C-string literals to reduce boilerplate Reduce boilerplate in doctests by replacing fallible function calls with literals.

Rollup merge of rust-lang#141511 - Noratrieb:codegen-fn-attrs, r=comp…

7cd749d

…iler-errors Cleanup CodegenFnAttrFlags - Rename `USED` to `USED_COMPILER` to better reflect its behavior. - Reorder some items to group the used and allocator flags together - Renumber them without gaps

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 25, 2025

bors merged commit 3d86494 into rust-lang:master May 25, 2025
7 checks passed

rustbot added this to the 1.89.0 milestone May 25, 2025

This was referenced May 25, 2025

Implement normalize_lexically #134696

Open

Make #[used(linker)] the default on ELF too #140872

Open

GuillaumeGomez deleted the rollup-ivjep2j branch May 25, 2025 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #141518

Rollup of 6 pull requests #141518

Uh oh!

GuillaumeGomez commented May 24, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented May 24, 2025

Uh oh!

bors commented May 24, 2025

Uh oh!

bors commented May 24, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

Uh oh!

rust-timer commented May 25, 2025

Uh oh!

github-actions bot commented May 25, 2025

Stage 0

Stage 1

Uh oh!

rust-timer commented May 25, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #141518

Rollup of 6 pull requests #141518

Uh oh!

Conversation

GuillaumeGomez commented May 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented May 24, 2025

Uh oh!

bors commented May 24, 2025

Uh oh!

bors commented May 24, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

Uh oh!

rust-timer commented May 25, 2025

Uh oh!

github-actions bot commented May 25, 2025

Test differences

Stage 0

Stage 1

Job duration changes

Uh oh!

rust-timer commented May 25, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

GuillaumeGomez commented May 24, 2025 •

edited by rustbot

Loading