core: Inherit the atomics module #14169
Closed
+857
−799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //! `&fmt::Arguments`, a `&str`, and a `uint. These three arguments dictate | ||
| //! the failure message, the file at which failure was invoked, and the line. | ||
| //! It is up to consumers of this core library to define this failure | ||
| //! function, it is only required to never return. |
There was a problem hiding this comment.
the , should be either a ; or a ..
Explain why it should not exist, and the plan of attack for removing it.
Due to our excellent macro hygiene, this involves having a global path and a hidden module in libcore itself.
bors
added a commit
that referenced
this pull request
May 14, 2014
This module is a foundation on which many other algorithms are built. When hardware support is missing, stubs are provided in libcompiler-rt.a, so this should be available on all platforms.
| @@ -9,6 +9,27 @@ | |||
| // except according to those terms. | |||
|
|
|||
| //! The Rust core library | |||
| //! | |||
| //! This library is meant to represent the core functionality of rust that is | |||
| //! maximally portable to other platforms. To that exent, this library has no | |||
There was a problem hiding this comment.
Oops, good catches! I'm piggy backing another PR to get these changes in.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 20, 2025
…less_late_init` (rust-lang#14169) fixes rust-lang#9895 changelog: [`needless_late_init`]: correct suggestion when assignments have enclosing parentheses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is a foundation on which many other algorithms are built. When hardware support is missing, stubs are provided in libcompiler-rt.a, so this should be available on all platforms.