Suppress warnings #14186
Merged
Suppress warnings #14186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1116,7 +1116,7 @@ mod test { | |||
| spawn(proc() { | |||
| tx.send(TcpStream::connect(addr.ip.to_str(), port).unwrap()); | |||
| }); | |||
| let l = rx.recv(); | |||
| let _ = rx.recv(); | |||
There was a problem hiding this comment.
This is a little subtly different than intended. This will destroy the received message immediately, but the message needs to live for the length of the block. Could you change the name to _l?
|
Could you squash the last commit into the first ones? Otherwise I think this is good to go! |
|
OK. I'll try. |
Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
On 32bit platforms, int is the same as i32, so 0xffffffff is "out of range." Annotating variables as u32 fixes the problems. Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
|
Done. r? |
|
... or roll-up? 😃 |
bors
added a commit
that referenced
this pull request
May 14, 2014
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
…ng#14186) The `needless_raw_string_hashes` lint was implemented in rust-lang#10884. However, the name originally considered might have been `unnecessary_raw_string_hashes`, so this part refers to a non-existent lint. r? flip1995 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.