tests: Split dont-shuffle-bswaps along opt-levels and arches #142176

workingjubilee · 2025-06-07T18:20:41Z

This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Fixes #142068

r? @nikic

nikic · 2025-06-08T09:05:55Z

tests/codegen/autovec/dont-shuffle-bswaps-opt2.rs

+// CHECK-NEXT: getelementptr inbounds{{( nuw)?}} i8, {{.+}} 12
+// CHECK-NEXT: store i16
+// CHECK-NEXT: getelementptr inbounds{{( nuw)?}} i8, {{.+}} 14
+// CHECK-NEXT: store i16


This previously only had the CHECK-NOT: shufflevector. I don't think we actually want to insist that -Copt-level=2 never vectorizes this code?

Oh, well! I believe this was the version of the test that you committed, but I am happy to apply Nikita's disagreements with Nikita :^)

nikic

r=me with nit resolved.

nikic · 2025-06-09T08:08:31Z

tests/codegen/autovec/dont-shuffle-bswaps-opt2.rs

@@ -0,0 +1,32 @@
+//@ revisions: OPT2
+//@[OPT2] compile-flags: -Copt-level=2


Don't need a revision here anymore, as there's just one now...

workingjubilee · 2025-06-10T00:40:28Z

@bors r=nikic rollup

bors · 2025-06-10T00:40:31Z

📌 Commit c7fd742 has been approved by nikic

It is now in the queue for this repository.

…-per-arch, r=nikic tests: Split dont-shuffle-bswaps along opt-levels and arches This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Rollup of 13 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142101 (core::ptr: deduplicate more method docs) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142260 (Miri subtree update) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142275 (rustdoc: Refractor `clean_ty_generics`) r? `@ghost` `@rustbot` modify labels: rollup

Some architectures gain target-cpu minimums in doing so.

workingjubilee · 2025-06-10T06:16:20Z

...sigh. I had somehow left in a revision that I thought I removed.

@bors r=nikic

bors · 2025-06-10T06:16:23Z

📌 Commit 6b0deb2 has been approved by nikic

It is now in the queue for this repository.

…-per-arch, r=nikic tests: Split dont-shuffle-bswaps along opt-levels and arches This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Rollup of 13 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142235 (Build rustc with assertions in `dist-alt` jobs) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) Failed merges: - #141942 (Implement representation options to smir) r? `@ghost` `@rustbot` modify labels: rollup

…-per-arch, r=nikic tests: Split dont-shuffle-bswaps along opt-levels and arches This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Rollup of 13 pull requests Successful merges: - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) - #142324 (Remove unneeded `FunctionCx` from some codegen methods) - #142328 (feat: Add `bit_width` for unsigned integer types) r? `@ghost` `@rustbot` modify labels: rollup

…-per-arch, r=nikic tests: Split dont-shuffle-bswaps along opt-levels and arches This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Rollup of 9 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - #140770 (add `extern "custom"` functions) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142248 (Add supported asm types for LoongArch32) - #142267 (assert more in release in `rustc_ast_lowering`) - #142274 (Update the stdarch submodule) - #142276 (Update dependencies in `library/Cargo.lock`) - #142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - #140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

Rollup merge of #142176 - workingjubilee:dont-shuffle-bswaps-per-arch, r=nikic tests: Split dont-shuffle-bswaps along opt-levels and arches This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Rollup of 9 pull requests Successful merges: - rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error) - rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - rust-lang/rust#140770 (add `extern "custom"` functions) - rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - rust-lang/rust#142248 (Add supported asm types for LoongArch32) - rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`) - rust-lang/rust#142274 (Update the stdarch submodule) - rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`) - rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#128425 (Make `missing_fragment_specifier` an unconditional error) - rust-lang#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - rust-lang#140770 (add `extern "custom"` functions) - rust-lang#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - rust-lang#142248 (Add supported asm types for LoongArch32) - rust-lang#142267 (assert more in release in `rustc_ast_lowering`) - rust-lang#142274 (Update the stdarch submodule) - rust-lang#142276 (Update dependencies in `library/Cargo.lock`) - rust-lang#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - rust-lang#140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

Rollup of 9 pull requests Successful merges: - rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error) - rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features) - rust-lang/rust#140770 (add `extern "custom"` functions) - rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - rust-lang/rust#142248 (Add supported asm types for LoongArch32) - rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`) - rust-lang/rust#142274 (Update the stdarch submodule) - rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`) - rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library) Failed merges: - rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various

rustbot assigned nikic Jun 7, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2025

This comment has been minimized.

Sign in to view

workingjubilee force-pushed the dont-shuffle-bswaps-per-arch branch from 863f870 to 786f88b Compare June 7, 2025 19:10

nikic reviewed Jun 8, 2025

View reviewed changes

workingjubilee force-pushed the dont-shuffle-bswaps-per-arch branch from 786f88b to d87c672 Compare June 8, 2025 15:32

nikic approved these changes Jun 9, 2025

View reviewed changes

tests: Copy dont-shuffle-bswaps per tested opt level

5906998

workingjubilee force-pushed the dont-shuffle-bswaps-per-arch branch from d87c672 to c7fd742 Compare June 10, 2025 00:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025

workingjubilee mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142278

Closed

tests: Revise dont-shuffle-bswaps-opt3 per tested arch

6b0deb2

Some architectures gain target-cpu minimums in doing so.

workingjubilee force-pushed the dont-shuffle-bswaps-per-arch branch from c7fd742 to 6b0deb2 Compare June 10, 2025 06:15

fmease mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142313

Closed

workingjubilee mentioned this pull request Jun 11, 2025

Rollup of 17 pull requests #142332

Closed

workingjubilee mentioned this pull request Jun 11, 2025

Rollup of 13 pull requests #142333

Closed

workingjubilee added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jun 11, 2025

workingjubilee mentioned this pull request Jun 12, 2025

Rollup of 15 pull requests #142396

Closed

workingjubilee mentioned this pull request Jun 12, 2025

Rollup of 15 pull requests #142397

Closed

matthiaskrgr mentioned this pull request Jun 13, 2025

Rollup of 9 pull requests #142443

Merged

bors merged commit 9daf8ea into rust-lang:master Jun 13, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tests: Split dont-shuffle-bswaps along opt-levels and arches #142176

tests: Split dont-shuffle-bswaps along opt-levels and arches #142176

Uh oh!

workingjubilee commented Jun 7, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

nikic Jun 8, 2025

Uh oh!

workingjubilee Jun 8, 2025

Uh oh!

nikic left a comment

Uh oh!

nikic Jun 9, 2025

Uh oh!

workingjubilee commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

workingjubilee commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,32 @@
		//@ revisions: OPT2
		//@[OPT2] compile-flags: -Copt-level=2

tests: Split dont-shuffle-bswaps along opt-levels and arches #142176

tests: Split dont-shuffle-bswaps along opt-levels and arches #142176

Uh oh!

Conversation

workingjubilee commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

nikic Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

workingjubilee Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

nikic Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

workingjubilee commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

workingjubilee commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

workingjubilee commented Jun 7, 2025 •

edited

Loading