Fast path for WF goals in new solver #142223

compiler-errors · 2025-06-09T03:01:18Z

Hopefully self-explanatory.

compiler-errors · 2025-06-09T03:01:37Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-09T03:01:41Z

⌛ Trying commit d5c1103 with merge d011188…

To cancel the try build, run the command @bors2 try cancel.

[perf] Fast path for WF goals in new solver I'll clean this up obviously, but I don't want to do that if this is worthless.

rust-bors · 2025-06-09T05:31:21Z

☀️ Try build successful (CI)
Build commit: d011188 (d011188561dc551d4a27a354ded5e031978279fa)

rust-timer · 2025-06-09T14:19:59Z

Finished benchmarking commit (d011188): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-5.4%, -0.2%]	13
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-13.6%, -1.0%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-4.1%, -2.7%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.176s -> 750.294s (-0.12%)
Artifact size: 372.27 MiB -> 372.18 MiB (-0.02%)

compiler-errors · 2025-06-09T17:56:10Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-09T17:56:14Z

⌛ Trying commit ec2a6d1 with merge e484b4d…

To cancel the try build, run the command @bors2 try cancel.

[perf] Fast path for WF goals in new solver I'll clean this up obviously, but I don't want to do that if this is worthless.

rust-bors · 2025-06-09T20:23:04Z

☀️ Try build successful (CI)
Build commit: e484b4d (e484b4dd6e21a71897157fc93c007fa79379dbf6)

rust-timer · 2025-06-09T23:00:47Z

Finished benchmarking commit (e484b4d): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-2.2%	[-5.0%, -0.2%]	15
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Max RSS (memory usage)

Results (primary 2.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.8%	[5.8%, 5.8%]	1
Regressions ❌ (secondary)	3.0%	[1.2%, 4.5%]	4
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-5.1%	[-14.1%, -0.9%]	4
All ❌✅ (primary)	2.1%	[-1.5%, 5.8%]	2

Cycles

Results (primary -1.5%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-2.9%	[-3.6%, -1.6%]	7
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 753.531s -> 754.864s (0.18%)
Artifact size: 372.34 MiB -> 372.30 MiB (-0.01%)

compiler-errors · 2025-06-10T16:11:14Z

r? lcnr

rustbot · 2025-06-10T16:11:19Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

compiler/rustc_trait_selection/src/solve/delegate.rs

Fast path for WF goals in new solver Hopefully self-explanatory.

rust-bors · 2025-06-13T20:33:40Z

☀️ Try build successful (CI)
Build commit: b131981 (b131981cb855cb562a3b497dfdd03f5402e87c5d, parent: 0d6ab209c525e276cbe7544cbd39a3c3619b6b18)

rust-timer · 2025-06-13T22:02:44Z

Finished benchmarking commit (b131981): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	3
Improvements ✅ (secondary)	-1.2%	[-3.3%, -0.1%]	15
All ❌✅ (primary)	0.2%	[-0.1%, 1.1%]	4

Max RSS (memory usage)

Results (primary 1.8%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.6%, 1.9%]	3
Regressions ❌ (secondary)	2.9%	[2.6%, 3.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-13.7%	[-13.7%, -13.7%]	1
All ❌✅ (primary)	1.8%	[1.6%, 1.9%]	3

Cycles

Results (secondary 6.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.3%	[6.3%, 6.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.964s -> 756.313s (0.05%)
Artifact size: 372.26 MiB -> 372.18 MiB (-0.02%)

lcnr · 2025-06-23T20:08:18Z

@bors r+

bors · 2025-06-23T20:08:22Z

📌 Commit 786df23 has been approved by lcnr

It is now in the queue for this repository.

compiler-errors · 2025-06-24T01:16:10Z

@bors r-

this needs a rebase

compiler-errors · 2025-06-26T00:09:39Z

@bors r=lcnr

bors · 2025-06-26T00:09:41Z

📌 Commit 92e60e9 has been approved by lcnr

It is now in the queue for this repository.

bors · 2025-06-27T03:57:48Z

⌛ Testing commit 92e60e9 with merge df32e15...

bors · 2025-06-27T07:07:33Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing df32e15 to master...

github-actions · 2025-06-27T07:10:49Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e61dd43 (parent) -> df32e15 (this PR)

Test differences

Show 10 test diffs

10 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard df32e15c56f582eb2bdde07711af6271f2ae660b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 6058.3s -> 6707.4s (10.7%)
x86_64-apple-2: 5350.2s -> 4798.5s (-10.3%)
dist-x86_64-apple: 8938.8s -> 8079.7s (-9.6%)
dist-powerpc64-linux: 5199.3s -> 4843.9s (-6.8%)
aarch64-apple: 4553.5s -> 4859.4s (6.7%)
x86_64-rust-for-linux: 2988.1s -> 2791.5s (-6.6%)
mingw-check-tidy: 73.2s -> 68.8s (-6.1%)
test-various: 4339.5s -> 4582.0s (5.6%)
dist-x86_64-netbsd: 4466.3s -> 4706.3s (5.4%)
x86_64-apple-1: 6875.9s -> 6529.1s (-5.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-27T13:56:54Z

Finished benchmarking commit (df32e15): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.1%]	8
Improvements ✅ (secondary)	-1.5%	[-3.5%, -0.3%]	13
All ❌✅ (primary)	-0.2%	[-0.4%, -0.1%]	8

Max RSS (memory usage)

Results (secondary -6.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.3%	[-12.3%, -2.6%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-2.6%, -0.9%]	7
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 692.733s -> 692.535s (-0.03%)
Artifact size: 372.08 MiB -> 371.99 MiB (-0.02%)

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 9, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 9, 2025

Auto merge of #142223 - compiler-errors:perf-wf, r=<try>

d011188

[perf] Fast path for WF goals in new solver I'll clean this up obviously, but I don't want to do that if this is worthless.

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025

compiler-errors force-pushed the perf-wf branch from d5c1103 to ec2a6d1 Compare June 9, 2025 17:54

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 9, 2025

Auto merge of #142223 - compiler-errors:perf-wf, r=<try>

e484b4d

[perf] Fast path for WF goals in new solver I'll clean this up obviously, but I don't want to do that if this is worthless.

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025

compiler-errors changed the title ~~[perf] Fast path for WF goals in new solver~~ Fast path for WF goals in new solver Jun 10, 2025

compiler-errors marked this pull request as ready for review June 10, 2025 16:11

rustbot assigned lcnr Jun 10, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2025

lcnr reviewed Jun 11, 2025

View reviewed changes

compiler/rustc_trait_selection/src/solve/delegate.rs Outdated Show resolved Hide resolved

compiler-errors force-pushed the perf-wf branch from ec2a6d1 to c1aca5a Compare June 11, 2025 22:37

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 13, 2025

Auto merge of #142223 - compiler-errors:perf-wf, r=<try>

b131981

Fast path for WF goals in new solver Hopefully self-explanatory.

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2025

compiler-errors added 2 commits June 24, 2025 01:42

Introduce trivial WF functions, use it in fast path

b8ef885

Apply fast path to old solver too

92e60e9

compiler-errors force-pushed the perf-wf branch from 786df23 to 92e60e9 Compare June 24, 2025 01:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2025

bors merged commit df32e15 into rust-lang:master Jun 27, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jun 27, 2025

bors mentioned this pull request Jun 27, 2025

Unify CoroutineWitness sooner in typeck, and stall coroutine obligations based off of TypingEnv #141762

Merged

rustbot removed the perf-regression Performance regression. label Jun 27, 2025

lcnr mentioned this pull request Jul 14, 2025

Next-generation trait solver rust-lang/rust-project-goals#113

Open

4 tasks

Fast path for WF goals in new solver #142223

Fast path for WF goals in new solver #142223

Uh oh!

Conversation

compiler-errors commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Jun 9, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 9, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

compiler-errors commented Jun 9, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 9, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

compiler-errors commented Jun 10, 2025

Uh oh!

rustbot commented Jun 10, 2025

Uh oh!

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 13, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 13, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

lcnr commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

compiler-errors commented Jun 24, 2025

Uh oh!

compiler-errors commented Jun 26, 2025

Uh oh!

bors commented Jun 26, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 27, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Uh oh!

compiler-errors commented Jun 9, 2025 •

edited

Loading