Add NonNull pattern types #142339
Open
Add NonNull pattern types #142339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE machinery changes to the core type system Some changes occurred in src/tools/clippy cc @rust-lang/clippy HIR ty lowering was modified cc @fmease Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt changes to the core type system Some changes occurred in compiler/rustc_codegen_ssa |
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
not-null-pattern-types
branch
from
02f19f4 to
57dc73a
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
not-null-pattern-types
branch
from
57dc73a to
0adc902
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
not-null-pattern-types
branch
from
0adc902 to
9944787
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
not-null-pattern-types
branch
from
9944787 to
8c271d9
Compare
| &mut self, | ||
| obligation: &PolyTraitObligation<'tcx>, | ||
| ) -> PredicateObligations<'tcx> { | ||
| debug!(?obligation, "confirm_fn_pointer_candidate"); |
There was a problem hiding this comment.
Possible copy-paste error:
Suggested change
| debug!(?obligation, "confirm_fn_pointer_candidate"); | |
| debug!(?obligation, "confirm_pointer_like_candidate"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the final piece missing for
We cannot use the previous scheme of using an integer range for raw pointers, as we're not just changing the layout of raw pointers anymore, but also the type representation. And we can't represent "any provenance or NonZero" natively as patterns. So I created a new
!nullpattern. Since this is all unstable representation stuff for replacing rustc_layout_scalar_range_start with pattern types, the divergence from normal patterns is fine, especially since T-lang seems interested in exploring general negation patternsr? @BoxyUwU