Skip to content

Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism #142563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
+17 −24
Merged

Refine run-make test ignores due to unpredictable i686-pc-windows-gnu unwind mechanism #142563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dbedaf
Refine run-make test ignores due to unpredictable `i686-pc-windows-gn…
jieyouxu Jun 16, 2025
aa8c6f8
Don't match on platform-specific directory not found message
jieyouxu Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/run-make/dump-ice-to-disk/rmake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
//!
//! # Test history
//!
//! - The previous rmake.rs iteration of this test was flakey for unknown reason on `i686-mingw`
//! *specifically*, so assertion failures in this test was made extremely verbose to help
//! diagnose why the ICE messages was different *specifically* on `i686-mingw`.
//! - An attempt is made to re-enable this test on `i686-mingw` (by removing `ignore-windows`). If
//! this test is still flakey, please restore the `ignore-windows` directive.
//@ ignore-windows
//FIXME(#128911): still flakey on i686-mingw.
//! The previous rmake.rs iteration of this test was flaky for unknown reason on
//! `i686-pc-windows-gnu` *specifically*, so assertion failures in this test was made extremely
//! verbose to help diagnose why the ICE messages was different. It appears that backtraces on
//! `i686-pc-windows-gnu` specifically are quite unpredictable in how many backtrace frames are
//! involved.
//@ ignore-cross-compile (exercising ICE dump on host)
//@ ignore-i686-pc-windows-gnu (unwind mechanism produces unpredictable backtraces)

use std::cell::OnceCell;
use std::path::{Path, PathBuf};
Expand Down
13 changes: 5 additions & 8 deletions tests/run-make/unstable-feature-usage-metrics-incremental/rmake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@
//!
//! # Test history
//!
//! - forked from dump-ice-to-disk test, which has flakeyness issues on i686-mingw, I'm assuming
//! those will be present in this test as well on the same platform
//! - Forked from `dump-ice-to-disk` test, which previously had backtrace unpredictability on
//! `i686-pc-windows-gnu`.
//@ needs-target-std
//@ ignore-windows
//FIXME(#128911): still flakey on i686-mingw.
//@ ignore-cross-compile (exercises metrics incremental on host)
//@ ignore-i686-pc-windows-gnu (unwind mechanism produces unpredictable backtraces)

use std::path::{Path, PathBuf};

Expand Down Expand Up @@ -87,9 +86,7 @@ fn test_metrics_errors() {
.env("RUST_BACKTRACE", "short")
.arg("-Zmetrics-dir=invaliddirectorythatdefinitelydoesntexist")
.run_fail()
.assert_stderr_contains(
"error: cannot dump feature usage metrics: No such file or directory",
)
.assert_stderr_contains("error: cannot dump feature usage metrics")
.assert_stdout_not_contains("internal compiler error");
});
}
12 changes: 4 additions & 8 deletions tests/run-make/unstable-feature-usage-metrics/rmake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@
//!
//! # Test history
//!
//! - forked from dump-ice-to-disk test, which has flakeyness issues on i686-mingw, I'm assuming
//! those will be present in this test as well on the same platform
//! - Forked from `dump-ice-to-disk` test, where `i686-pc-windows-gnu` has unpredictable backtraces.
//@ needs-target-std
//@ ignore-windows
//FIXME(#128911): still flakey on i686-mingw.
//@ ignore-cross-compile (exercises metrics dump on host)
//@ ignore-i686-pc-windows-gnu (unwind mechanism produces unpredictable backtraces)

use std::path::{Path, PathBuf};

Expand Down Expand Up @@ -85,9 +83,7 @@ fn test_metrics_errors() {
.env("RUST_BACKTRACE", "short")
.arg("-Zmetrics-dir=invaliddirectorythatdefinitelydoesntexist")
.run_fail()
.assert_stderr_contains(
"error: cannot dump feature usage metrics: No such file or directory",
)
.assert_stderr_contains("error: cannot dump feature usage metrics")
.assert_stdout_not_contains("internal compiler error");
});
}
Loading