trait_sel: add builtin impl for PointeeSized
#142663
Open
+100
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During review of rust-lang#137944, we thought we could remove the builtin impl of `PointeeSized` as it was removed during lowering, but users can still write `dyn PointeeSized` and so we need the builtin impl.
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
|
Do we even want to allow I'd somewhat opt to just rejecting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142652
Supersedes #142661
During review of #137944, we thought we could remove the builtin impl of
PointeeSizedas it was removed during lowering, but users can still writedyn PointeeSizedand so we need the builtin impl.r? @oli-obk