Update GCC backend subtree #142669

GuillaumeGomez · 2025-06-18T12:11:18Z

No description provided.

…update_cg_gcc_2025-05-14

…dler

Add missing `add_eval` to generate `__rdl_oom` in the alloc error handler

make `rustc_attr_parsing` less dominant in the rustc crate graph It has/had a glob re-export of `rustc_attr_data_structures`, which is a crate much lower in the graph, and a lot of crates were using it *just* (or *mostly*) for that re-export, while they can rely on `rustc_attr_data_structures` directly. Previous graph: ![graph_1](https://github.com/user-attachments/assets/f4a5f13c-4222-4903-b56d-28c83511fcbd) Graph with this PR: ![graph_2](https://github.com/user-attachments/assets/1e053d9c-75cc-402b-84df-86229c98277a) The first commit keeps the re-export, and just changes the dependency if possible. The second commit is the "breaking change" which removes the re-export, and "explicitly" adds the `rustc_attr_data_structures` dependency where needed. It also switches over some src/tools/*. The second commit is actually a lot more involved than I expected. Please let me know if it's a better idea to back it out and just keep the first commit.

…resentation

Changes to constant handling - faster deduplication, more compact represtntation

Add spell checking job in the CI

…e types are supported

… even with cg_llvm

Fix to 128 bit int unaligned loads

Add support for easily fuzzing `cg_gcc` with rustlantis

modifed y.sh to allow for running cargo tests.

…embly

…5_21 Sync from rust 2025/05/21

Added some bare-bones support for explict registers in ARM inline assembly

Fix fuzz warnings and deny warnings by default in build system

rustbot · 2025-06-18T12:11:24Z

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-06-18T12:11:26Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

antoyo

Thanks for making this PR!

…update_cg_gcc_2025-06-18

rustbot · 2025-06-18T13:11:55Z

⚠️ Warning ⚠️

The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- 1e96d86
- 3d962df
- 485e43f
- 640c067
- 706905b
- 721ac5a
- 7cc33be
- 82d7cd4
- 8efeb49
- 967fc29
- 9aec231
- ac500d4
- acfb046
- b15114f
- b4be0b9
- c48d8d4
- d80802b
- e58e697
- f518ec5
- fda0bb9
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease
```

GuillaumeGomez · 2025-06-18T14:58:33Z

@bors r+ rollup=never p=1

bors · 2025-06-18T14:58:36Z

📌 Commit 8648405 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-06-18T15:00:14Z

⌛ Testing commit 8648405 with merge f9c15f4...

bors · 2025-06-18T17:56:19Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing f9c15f4 to master...

github-actions · 2025-06-18T17:59:18Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6f935a0 (parent) -> f9c15f4 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f9c15f40fbd7b4ba1baea6fb89551274047e17b3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 5798.3s -> 9430.6s (62.6%)
dist-aarch64-apple: 6158.2s -> 4853.1s (-21.2%)
i686-gnu-2: 6187.3s -> 5396.2s (-12.8%)
x86_64-rust-for-linux: 2905.0s -> 2543.3s (-12.4%)
i686-gnu-nopt-1: 8177.2s -> 7184.2s (-12.1%)
x86_64-gnu-llvm-19-1: 3688.3s -> 3292.8s (-10.7%)
i686-gnu-1: 8234.2s -> 7374.2s (-10.4%)
aarch64-apple: 5607.4s -> 5031.0s (-10.3%)
x86_64-gnu-debug: 5925.5s -> 5329.2s (-10.1%)
dist-aarch64-msvc: 8331.1s -> 9166.2s (10.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-19T02:10:22Z

Finished benchmarking commit (f9c15f4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 693.627s -> 694.089s (0.07%)
Artifact size: 371.96 MiB -> 372.00 MiB (0.01%)

GuillaumeGomez and others added 30 commits May 14, 2025 13:51

Merge commit '6ba33f5e1189a5ae58fb96ce3546e76b13d090f5' into subtree-…

d52b5e6

…update_cg_gcc_2025-05-14

Update gcc version used in rustc_codegen_version

3cec08a

Add missing add_eval to generate __rdl_oom in the alloc error han…

f064896

…dler

Merge pull request rust-lang#676 from GuillaumeGomez/rdl_room

7cc33be

Add missing `add_eval` to generate `__rdl_oom` in the alloc error handler

Remove rustc_attr_data_structures re-export from rustc_attr_parsing

f36e8f5

Changes to constant handling - faster deduplication, more compact rep…

82160c4

…resentation

Merge pull request rust-lang#680 from FractalFir/master

3d962df

Changes to constant handling - faster deduplication, more compact represtntation

Add spell checking job in the CI

90a007c

Fix typos

c430b87

Merge pull request rust-lang#681 from rust-lang/test/typos

9aec231

Add spell checking job in the CI

Merge branch 'master' into sync_from_rust_2025_05_21

721ac5a

Update to nightly-2025-05-21

ce3dae9

Implement missing f16/f128 builtins

593d7ca

Only specify that we have reliable f16 and f128 on targets where thos…

dca28e5

…e types are supported

Fix f128 intrinsics

dd6d5e2

Skip the core test f16::test_total_cmp because it fails in debug mode…

f1d5cfe

… even with cg_llvm

Fix to 128 bit int unaligned loads

1afdb55

Merge pull request rust-lang#684 from FractalFir/master

d80802b

Fix to 128 bit int unaligned loads

modifed y.sh to allow for running cargo tests.

d098c8a

Added support for easy fuzzing with rustlantis

22ca124

Removed some env vars from the CI

ea03697

Merge pull request rust-lang#688 from FractalFir/fuzz_support

967fc29

Add support for easily fuzzing `cg_gcc` with rustlantis

Merge pull request rust-lang#669 from FractalFir/y_cargo_tests

706905b

modifed y.sh to allow for running cargo tests.

Pin compiler_builtins to 0.1.160 to fix some f128 tests

ac69f1e

Added some bare-bones support for explict registers in ARM inline ass…

267f94e

…embly

Fix cast from u128 to f128

ba53d97

Merge pull request rust-lang#682 from rust-lang/sync_from_rust_2025_0…

8efeb49

…5_21 Sync from rust 2025/05/21

Merge pull request rust-lang#692 from FractalFir/arm_asm

ac500d4

Added some bare-bones support for explict registers in ARM inline assembly

Changed intrinsic generation

659d996

Merge pull request rust-lang#713 from GuillaumeGomez/fix-warnings

fda0bb9

Fix fuzz warnings and deny warnings by default in build system

rustbot assigned WaffleLapkin Jun 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2025

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2025

antoyo approved these changes Jun 18, 2025

View reviewed changes

GuillaumeGomez force-pushed the subtree-update_cg_gcc_2025-06-18 branch from 693f386 to 9ead7af Compare June 18, 2025 13:08

This comment has been minimized.

Sign in to view

Merge commit 'fda0bb9588912a3e0606e880ca9f6e913cf8a5a4' into subtree-…

c48d8d4

…update_cg_gcc_2025-06-18

GuillaumeGomez force-pushed the subtree-update_cg_gcc_2025-06-18 branch from 9ead7af to c48d8d4 Compare June 18, 2025 13:11

This comment has been minimized.

Sign in to view

GCC backend: Remove add_eval if no function is created

8648405

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 18, 2025

bors merged commit f9c15f4 into rust-lang:master Jun 18, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 18, 2025

GuillaumeGomez deleted the subtree-update_cg_gcc_2025-06-18 branch June 18, 2025 17:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update GCC backend subtree #142669

Update GCC backend subtree #142669

Uh oh!

GuillaumeGomez commented Jun 18, 2025

Uh oh!

rustbot commented Jun 18, 2025

Uh oh!

rustbot commented Jun 18, 2025

Uh oh!

This comment has been minimized.

antoyo left a comment

Uh oh!

This comment has been minimized.

rustbot commented Jun 18, 2025

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

rust-timer commented Jun 19, 2025

Uh oh!

Uh oh!

Update GCC backend subtree #142669

Update GCC backend subtree #142669

Uh oh!

Conversation

GuillaumeGomez commented Jun 18, 2025

Uh oh!

rustbot commented Jun 18, 2025

Uh oh!

rustbot commented Jun 18, 2025

Uh oh!

This comment has been minimized.

antoyo left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Jun 18, 2025

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 19, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!