Skip to content

Add a few inline directives in rustc_serialize. #142856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Add a few inline directives in rustc_serialize. #142856

merged 1 commit into from
Jun 22, 2025

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 21, 2025 •
edited
Loading

I see debug_strict_add and debug_strict_sub appearing in callgrind output. This bothers me. This PR should make them disappear.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 21, 2025
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2025
@bors
Copy link
Collaborator

bors commented Jun 21, 2025

⌛ Trying commit 8e9552a with merge 21c095a...

bors added a commit that referenced this pull request Jun 21, 2025
@bors
Auto merge of #142856 - cjgillot:inline-serialize, r=<try>
21c095a 
Add a few inline directives in rustc_serialize.

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jun 22, 2025

☀️ Try build successful - checks-actions
Build commit: 21c095a (21c095a6e0d6615d122664c08333a0ec03393235)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (21c095a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.5% [-4.5%, -4.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 691.957s -> 689.832s (-0.31%)
Artifact size: 371.85 MiB -> 371.94 MiB (0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2025
@cjgillot
Copy link
Contributor Author

No effect in icount, but small consistent effect on cycles and bootstrap time.
r? compiler

@cjgillot cjgillot marked this pull request as ready for review June 22, 2025 08:31
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2025
@petrochenkov
Copy link
Contributor

@bors r+ rollup=maybe

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 8e9552a has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 22, 2025
Merged
bors added a commit that referenced this pull request Jun 22, 2025
@bors
Auto merge of #142878 - GuillaumeGomez:rollup-53dohob, r=GuillaumeGomez
111e9bc 
Rollup of 10 pull requests

Successful merges:

 - #142458 (Merge unboxed trait object error suggestion into regular dyn incompat error)
 - #142593 (Add a warning to LateContext::get_def_path)
 - #142594 (Add DesugaringKind::FormatLiteral)
 - #142740 (Clean-up `FnCtxt::is_destruct_assignment_desugaring`)
 - #142780 (Port `#[must_use]` to new attribute parsing infrastructure)
 - #142798 (Don't fail to parse a struct if a semicolon is used to separate fields)
 - #142856 (Add a few inline directives in rustc_serialize.)
 - #142868 (remove few allow(dead_code))
 - #142874 (cranelift: fix target feature name typo: "fxsr")
 - #142877 (Document why tidy checks if `eslint` is installed via `npm`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0f89e61 into rust-lang:master Jun 22, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 22, 2025
rust-timer added a commit that referenced this pull request Jun 22, 2025
@rust-timer
Unrolled build for #142856
296cd6e 
Rollup merge of #142856 - cjgillot:inline-serialize, r=petrochenkov

Add a few inline directives in rustc_serialize.

I see `debug_strict_add` and `debug_strict_sub` appearing in callgrind output. This bothers me. This PR should make them disappear.
@cjgillot cjgillot deleted the inline-serialize branch June 22, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cjgillot @rust-timer @bors @petrochenkov @rustbot