Skip to content

Use let chains in the new solver #143066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Use let chains in the new solver #143066

merged 2 commits into from
Jun 30, 2025

Conversation

@compiler-errors
Copy link
Member

Self-explanatory

Let chains are stable as of today

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 26, 2025
compiler-errors
compiler-errors commented Jun 26, 2025
View reviewed changes
compiler-errors
compiler-errors commented Jun 26, 2025
View reviewed changes
@yotamofek yotamofek mentioned this pull request Jun 26, 2025
Merged
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
@compiler-errors
Rollup merge of rust-lang#143073 - yotamofek:pr/fix-let-chains-fixmes…
cb0b621 
…, r=compiler-errors

Fix some fixmes that were waiting for let chains

Was inspired by looking at rust-lang#143066 and spotting two fixmes that were missed, so... r? `@compiler-errors`  😅

Yay, let chains!
rust-timer added a commit that referenced this pull request Jun 27, 2025
@rust-timer
Unrolled build for #143073
2c0d666 
Rollup merge of #143073 - yotamofek:pr/fix-let-chains-fixmes, r=compiler-errors

Fix some fixmes that were waiting for let chains

Was inspired by looking at #143066 and spotting two fixmes that were missed, so... r? `@compiler-errors`  😅

Yay, let chains!
lcnr
lcnr reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without converting the relevant functions to if <let-chain> { value } else { value } instead of an explicit early return

@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

📌 Commit ccbe983 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 29, 2025
@GuillaumeGomez
Rollup merge of rust-lang#143066 - compiler-errors:let-chain-solver, …
a4fea51 
…r=lcnr

Use let chains in the new solver

Self-explanatory

Let chains are stable as of today

r? lcnr
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 29, 2025
Closed
bors added a commit that referenced this pull request Jun 29, 2025
@bors
Auto merge of #143211 - GuillaumeGomez:rollup-ug242zk, r=GuillaumeGomez
012c38d 
Rollup of 7 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #143066 (Use let chains in the new solver)
 - #143156 (inherit `#[align]` from trait method prototypes)
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143194 (fix bitcast of single-element SIMD vectors)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2025
@matthiaskrgr
Rollup merge of rust-lang#143066 - compiler-errors:let-chain-solver, …
83a0f1d 
…r=lcnr

Use let chains in the new solver

Self-explanatory

Let chains are stable as of today

r? lcnr
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2025
Closed
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143225 - matthiaskrgr:rollup-v6ynl5f, r=matthiaskrgr
3a6a679 
Rollup of 7 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #143066 (Use let chains in the new solver)
 - #143156 (inherit `#[align]` from trait method prototypes)
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
@dianqk dianqk mentioned this pull request Jun 30, 2025
Merged
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
c65dcca 
Rollup of 14 pull requests

Successful merges:

 - #142429 (`tests/ui`: A New Order [13/N])
 - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - #143066 (Use let chains in the new solver)
 - #143090 (Workaround for memory unsafety in third party DLLs)
 - #143118 (`tests/ui`: A New Order [15/N])
 - #143159 (Do not freshen `ReError`)
 - #143168 (`tests/ui`: A New Order [16/N])
 - #143176 (fix typos and improve clarity in documentation)
 - #143187 (Add my work email to mailmap)
 - #143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - #143195 (`tests/ui`: A New Order [17/N])
 - #143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - #143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8c4bcb8 into rust-lang:master Jun 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 30, 2025
rust-timer added a commit that referenced this pull request Jun 30, 2025
@rust-timer
Unrolled build for #143066
6ce6247 
Rollup merge of #143066 - compiler-errors:let-chain-solver, r=lcnr

Use let chains in the new solver

Self-explanatory

Let chains are stable as of today

r? lcnr
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
d02672d 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/stdarch that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
51f0bad 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 3, 2025
@bors
Auto merge of #143233 - dianqk:rollup-lcx3278, r=dianqk
9b379be 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang/rust#143066 (Use let chains in the new solver)
 - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang/rust#143159 (Do not freshen `ReError`)
 - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang/rust#143176 (fix typos and improve clarity in documentation)
 - rust-lang/rust#143187 (Add my work email to mailmap)
 - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 4, 2025
@bors
Auto merge of rust-lang#143233 - dianqk:rollup-lcx3278, r=dianqk
3aefdd2 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#142429 (`tests/ui`: A New Order [13/N])
 - rust-lang#142514 (Miri: handling of SNaN inputs in `f*::pow` operations)
 - rust-lang#143066 (Use let chains in the new solver)
 - rust-lang#143090 (Workaround for memory unsafety in third party DLLs)
 - rust-lang#143118 (`tests/ui`: A New Order [15/N])
 - rust-lang#143159 (Do not freshen `ReError`)
 - rust-lang#143168 (`tests/ui`: A New Order [16/N])
 - rust-lang#143176 (fix typos and improve clarity in documentation)
 - rust-lang#143187 (Add my work email to mailmap)
 - rust-lang#143190 (Use the `new` method for `BasicBlockData` and `Statement`)
 - rust-lang#143195 (`tests/ui`: A New Order [17/N])
 - rust-lang#143196 (Port #[link_section] to the new attribute parsing infrastructure)
 - rust-lang#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again)
 - rust-lang#143219 (Show auto trait and blanket impls for `!`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

4 participants

@compiler-errors @lcnr @bors @rustbot