add multi-arch asm! label operand test #143227

tshepang · 2025-06-30T05:50:18Z

Added this since the other label operand tests are only for x86

rustbot · 2025-06-30T05:50:23Z

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lcnr · 2025-06-30T06:07:56Z

don't know how label works

r? @Amanieu maybe

Amanieu · 2025-06-30T08:46:06Z

tests/ui/asm/label-operand.rs

@@ -0,0 +1,47 @@
+//@ run-pass
+//@ needs-asm-support


This is going to fail on targets that aren't x86, arm or risc-v. Either add a fallback or split this into separate tests that are only enabled for that particular architecture.

1633: [1.88] add test: inline assembly label operand r=Hoverbear a=tshepang Backports rust-lang/rust#143227 as we need it for satisfying traceability matrix. Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>

apiraino · 2025-08-28T13:36:34Z

Switching to waiting on author due to this comment. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

Dylan-DPC · 2025-09-27T09:45:20Z

@tshepang any updates on this? thanks

tshepang · 2025-09-27T22:38:14Z

let me do this within a week

Others in the file skip the module name

rustbot · 2025-10-04T22:07:50Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2025-10-04T22:07:52Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tshepang · 2025-10-04T22:12:31Z

@rustbot ready

Amanieu · 2025-10-05T04:53:27Z

tests/ui/asm/label-operand.rs

+}
+
+// fallback
+#[cfg(other)]


This isn't needed any more, just don't execute any revision at all if none of the needs-* predicates match.

would this mean the test will fail if another arch gets support for inline assembly

If you just remove other from the list of revisions at the top of the file then this test simply won't execute for any architectures other than the ones listed.

oh, that I did not expect... thought other archs would still run main and fail due to missing fn make_true

tshepang · 2025-10-07T09:27:02Z

@bors ready

Amanieu · 2025-10-08T22:09:01Z

@bors r+

bors · 2025-10-08T22:09:04Z

📌 Commit c7d180c has been approved by Amanieu

It is now in the queue for this repository.

bors · 2025-10-09T02:23:42Z

⌛ Testing commit c7d180c with merge bd34871...

bors · 2025-10-09T05:34:22Z

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing bd34871 to master...

github-actions · 2025-10-09T05:37:30Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 61efd19 (parent) -> bd34871 (this PR)

Test differences

Show 20 test diffs

Stage 1

[ui] tests/ui/asm/label-operand.rs#aarch64: [missing] -> ignore (only executed when the architecture is aarch64) (J4)
[ui] tests/ui/asm/label-operand.rs#arm: [missing] -> ignore (only executed when the architecture is arm) (J4)
[ui] tests/ui/asm/label-operand.rs#arm64ec: [missing] -> ignore (only executed when the architecture is arm64ec) (J4)
[ui] tests/ui/asm/label-operand.rs#riscv32: [missing] -> ignore (only executed when the architecture is riscv32) (J4)
[ui] tests/ui/asm/label-operand.rs#riscv64: [missing] -> ignore (only executed when the architecture is riscv64) (J4)
[ui] tests/ui/asm/label-operand.rs#x86: [missing] -> ignore (only executed when the architecture is x86) (J4)
[ui] tests/ui/asm/label-operand.rs#x86_64: [missing] -> pass (J4)

Stage 2

[ui] tests/ui/asm/label-operand.rs#aarch64: [missing] -> pass (J0)
[ui] tests/ui/asm/label-operand.rs#aarch64: [missing] -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/asm/label-operand.rs#x86: [missing] -> ignore (only executed when the architecture is x86) (J2)
[ui] tests/ui/asm/label-operand.rs#arm: [missing] -> ignore (only executed when the architecture is arm) (J3)
[ui] tests/ui/asm/label-operand.rs#arm64ec: [missing] -> ignore (only executed when the architecture is arm64ec) (J5)
[ui] tests/ui/asm/label-operand.rs#riscv32: [missing] -> ignore (only executed when the architecture is riscv32) (J5)
[ui] tests/ui/asm/label-operand.rs#riscv64: [missing] -> ignore (only executed when the architecture is riscv64) (J5)
[ui] tests/ui/asm/label-operand.rs#x86_64: [missing] -> pass (J6)
[ui] tests/ui/asm/label-operand.rs#arm: [missing] -> pass (J7)
[ui] tests/ui/asm/label-operand.rs#x86: [missing] -> pass (J8)
[ui] tests/ui/asm/label-operand.rs#x86_64: [missing] -> ignore (only executed when the architecture is x86_64) (J9)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bd3487101ff9397ca8a54dd83aa360d93342b82e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 6220.4s -> 7487.4s (20.4%)
aarch64-gnu-llvm-20-1: 3295.2s -> 3820.9s (16.0%)
aarch64-msvc-2: 4796.9s -> 5466.3s (14.0%)
aarch64-gnu-llvm-20-2: 2190.8s -> 2462.2s (12.4%)
dist-aarch64-msvc: 7188.1s -> 6345.8s (-11.7%)
x86_64-gnu-tools: 3266.2s -> 3642.7s (11.5%)
dist-apple-various: 4798.1s -> 4246.5s (-11.5%)
x86_64-gnu-miri: 4338.6s -> 4815.4s (11.0%)
dist-x86_64-windows-gnullvm: 4763.4s -> 5281.0s (10.9%)
x86_64-gnu-llvm-20: 2441.1s -> 2699.0s (10.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-09T07:46:34Z

Finished benchmarking commit (bd34871): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.2%	[-4.2%, -4.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.5%	[-4.2%, 1.3%]	2

Cycles

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.034s -> 474.495s (0.31%)
Artifact size: 388.41 MiB -> 388.40 MiB (-0.00%)

rustbot assigned lcnr Jun 30, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025

rustbot assigned Amanieu and unassigned lcnr Jun 30, 2025

Amanieu reviewed Jun 30, 2025

View reviewed changes

tshepang mentioned this pull request Jul 1, 2025

document Rust 1.87 ferrocene/ferrocene#1542

Merged

Hoverbear mentioned this pull request Aug 6, 2025

[1.88] add test: inline assembly label operand ferrocene/ferrocene#1633

Merged

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025

Hoverbear added a commit to ferrocene/ferrocene that referenced this pull request Oct 3, 2025

Cherry pick rust-lang/rust#143227 for fls_mw7mth5ooeq1 annotation

e06bc1f

Hoverbear added a commit to ferrocene/ferrocene that referenced this pull request Oct 3, 2025

Cherry pick rust-lang/rust/pull/143227 for fls_mw7mth5ooeq1 annotation

530fd99

Hoverbear added a commit to ferrocene/ferrocene that referenced this pull request Oct 3, 2025

Cherry pick rust-lang/rust#143227 for fls_mw7mth5ooeq1 annotation

4148ce8

a consistency fix

5a38eb1

Others in the file skip the module name

tshepang force-pushed the asm-label-operand branch from 46f857f to 3b703ea Compare October 4, 2025 22:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2025

Amanieu reviewed Oct 5, 2025

View reviewed changes

add multi-arch asm! label operand test

c7d180c

tshepang force-pushed the asm-label-operand branch from 3b703ea to c7d180c Compare October 7, 2025 09:23

rustbot added the A-compiletest Area: The compiletest test runner label Oct 7, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 7, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2025

bors merged commit bd34871 into rust-lang:master Oct 9, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 9, 2025

tshepang deleted the asm-label-operand branch October 9, 2025 05:48

github-actions bot mentioned this pull request Oct 15, 2025

Toolchain upgrade to nightly-2025-10-10 flux-rs/flux#1332

Closed

add multi-arch asm! label operand test #143227

add multi-arch asm! label operand test #143227

Uh oh!

Conversation

tshepang commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 30, 2025

Uh oh!

lcnr commented Jun 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apiraino commented Aug 28, 2025

Uh oh!

Dylan-DPC commented Sep 27, 2025

Uh oh!

tshepang commented Sep 27, 2025

Uh oh!

rustbot commented Oct 4, 2025

Uh oh!

rustbot commented Oct 4, 2025

Uh oh!

tshepang commented Oct 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tshepang commented Oct 7, 2025

Uh oh!

Amanieu commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

bors commented Oct 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 9, 2025

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tshepang commented Jun 30, 2025 •

edited

Loading