Skip to content

Make tests/ui/abi/debug.rs cross-compile #143464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Jul 5, 2025

Resumption of #141979, making the test cross-compile.

@YingkaiLi-VM My apologies if this is undesired. 64bec0f was the two lines of difference needed. Feel free to reopen a new version of your PR if you would rather rebase and fix it up again.

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2025
@rust-log-analyzer

This comment has been minimized.

@workingjubilee workingjubilee force-pushed the make-debug-rs-cross-compile branch from 2f41577 to 64bec0f Compare July 5, 2025 01:14
@workingjubilee
Copy link
Member Author

Two lines.

@YingkaiLi-VM
Copy link

@workingjubilee As a newcomer to the Rust community and related work, I realize our PR discussions might have contained some miscommunications – I sincerely appreciate your time and patience throughout. Thank you especially for your revisions to the PR!
Could you clarify whether I still need to make any changes to it?
Truly appreciate your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants