Add profiler to bootstrap command #143525
Draft
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-bootstrap
Kobzol
reviewed
Jul 6, 2025
| @@ -679,6 +754,8 @@ impl<'a> DeferredCommand<'a> { | |||
| && let (Some(cache_key), Some(_)) = (&cache_key, output.status()) | |||
| { | |||
| exec_ctx.command_cache.insert(cache_key.clone(), output.clone()); | |||
| let duration = start_time.elapsed(); | |||
| exec_ctx.profiler.record(cache_key.clone(), duration); | |||
There was a problem hiding this comment.
We should ideally record also the uncached commands. I guess that we could reuse the CacheKey logic to avoid introducing another approach for identifying the commands. So maybe let all commands return a cache key, and add a separate method for figuring out if caching is enabled or not? And maybe rename CacheKey to CommandFingerprint or something.
| @@ -545,6 +607,7 @@ impl ExecutionContext { | |||
| { | |||
| command.mark_as_executed(); | |||
| self.verbose(|| println!("Cache hit: {command:?}")); | |||
| self.profiler.record(cache_key.unwrap(), Duration::from_secs(0)); | |||
There was a problem hiding this comment.
We should represent this in a proper way, e.g. store a Vec of execution traces, where each trace is either a cache hit, or an actual execution with a duration.
| let mut stats = self.stats.lock().unwrap(); | ||
| let entry = stats.entry(key).or_default(); | ||
| entry.count += 1; | ||
| entry.max_duration = std::cmp::max(entry.max_duration, duration); |
There was a problem hiding this comment.
Let's store all the durations, shouldn't be that expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds command profiling to the bootstrap command. It tracks the total execution time and records cache hits for each command. It also provides the ability to export execution result to a JSON file. Integrating this with Chrome tracing could further enhance observability.
r? @Kobzol