Constify some more `Result` functions #143771

Randl · 2025-07-11T07:22:31Z

No description provided.

rustbot · 2025-07-11T07:22:36Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/ui/traits/const-traits/const-traits-result.rs

library/core/src/result.rs

tgross35 · 2025-07-11T07:38:08Z

Cc @rust-lang/wg-const-eval @rust-lang/libs-api, there is a lot here. Are we in "constify everything" mode, or what is a reasonable level of discretion?

oli-obk · 2025-07-11T07:39:31Z

We are in "constifying everything mode", yes

library/core/src/result.rs

lcnr · 2025-07-11T07:49:56Z

Have we decided on the const Trait bound syntax again and what's the current rustdoc output for these 🤔 Haven't followed the recent progress here and want to be sure we don't partially constify std only to have to change it again in the future

oli-obk · 2025-07-11T08:00:43Z

Have we decided on the const Trait bound syntax again and what's the current rustdoc output for these 🤔 Haven't followed the recent progress here and want to be sure we don't partially constify std only to have to change it again in the future

we're in a chicken-egg situation: T-lang wants hands on experience with this syntax (well [const], but that will automatically happen via rustfmt on the next beta bump). But without that experience we won't get a final decision.

So no real decision yet, but also not as much trouble as it was considering we don't need to cfg(bootstrap) libcore anymore

library/core/src/result.rs

library/coretests/tests/result.rs

tgross35 · 2025-07-11T20:56:09Z

After updating the feature gate and tracking issue, I think this will be pretty good. Please squash with a reasonable commit message.

tgross35 · 2025-07-18T17:54:02Z

@rustbot author

rustbot · 2025-07-18T17:54:05Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Randl · 2025-07-20T11:06:54Z

@rustbot ready

tgross35

One request above then lgtm from a libs perspective. Typically libs-api needs to give the okay for unstable user-visible changes, but per #144289 (comment) traits are wg-const-eval. So for the API changes:

r? @rust-lang/wg-const-eval

library/coretests/tests/result.rs

RalfJung · 2025-08-01T07:25:02Z

I'm heading out for vacation soon so won't have time to review this for a while. Also I haven't been following const-traits much, that was mostly @oli-obk (also on vacation) and @fee1-dead.

@tgross35 I'm entirely fine with you landing this if you're happy with it, given it's all unstable.

tgross35 · 2025-08-01T08:04:09Z

That works for me, enjoy the 🌴

Thank you for putting this together @Randl!

@bors r+

bors · 2025-08-01T08:04:12Z

📌 Commit 9377e0a has been approved by tgross35

It is now in the queue for this repository.

Constify some more `Result` functions

Rollup of 18 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143771 (Constify some more `Result` functions) - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144185 (Document guarantees of poisoning) - #144395 (update fortanix tests) - #144478 (Improve formatting of doc code blocks) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - #144786 (Cleanup the definition of `group_type`) - #144796 (Add my previous commit name to .mailmap) - #144797 (Update safety comment for new_unchecked in niche_types) Failed merges: - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143771 (Constify some more `Result` functions) - #144185 (Document guarantees of poisoning) - #144395 (update fortanix tests) - #144478 (Improve formatting of doc code blocks) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - #144786 (Cleanup the definition of `group_type`) - #144796 (Add my previous commit name to .mailmap) - #144797 (Update safety comment for new_unchecked in niche_types) - #144803 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143771 - Randl:const-result, r=tgross35 Constify some more `Result` functions

Rollup of 17 pull requests Successful merges: - rust-lang/rust#132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - rust-lang/rust#143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - rust-lang/rust#143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - rust-lang/rust#143771 (Constify some more `Result` functions) - rust-lang/rust#144185 (Document guarantees of poisoning) - rust-lang/rust#144395 (update fortanix tests) - rust-lang/rust#144478 (Improve formatting of doc code blocks) - rust-lang/rust#144614 (Fortify RemoveUnneededDrops test.) - rust-lang/rust#144703 ([test][AIX] ignore extern_weak linkage test) - rust-lang/rust#144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - rust-lang/rust#144756 (detect infinite recursion with tail calls in ctfe) - rust-lang/rust#144766 (Add human readable name "Cygwin") - rust-lang/rust#144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - rust-lang/rust#144786 (Cleanup the definition of `group_type`) - rust-lang/rust#144796 (Add my previous commit name to .mailmap) - rust-lang/rust#144797 (Update safety comment for new_unchecked in niche_types) - rust-lang/rust#144803 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Constify some more `Result` functions

rustbot assigned tgross35 Jul 11, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 11, 2025

tgross35 reviewed Jul 11, 2025

View reviewed changes

tests/ui/traits/const-traits/const-traits-result.rs Outdated Show resolved Hide resolved

library/core/src/result.rs Outdated Show resolved Hide resolved

oli-obk changed the title ~~Constify some more Result funstions~~ Constify some more Result functions Jul 11, 2025

RalfJung reviewed Jul 11, 2025

View reviewed changes

library/core/src/result.rs Outdated Show resolved Hide resolved

RalfJung reviewed Jul 11, 2025

View reviewed changes

library/core/src/result.rs Outdated Show resolved Hide resolved

oli-obk reviewed Jul 11, 2025

View reviewed changes

library/core/src/result.rs Outdated Show resolved Hide resolved

tgross35 reviewed Jul 11, 2025

View reviewed changes

library/coretests/tests/result.rs Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 18, 2025

Randl mentioned this pull request Jul 20, 2025

Tracking Issue for more const methods on Result #144211

Open

3 tasks

Randl force-pushed the const-result branch from 73b4699 to 0baf3ab Compare July 20, 2025 08:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2025

Randl requested a review from tgross35 July 29, 2025 05:03

tgross35 approved these changes Aug 1, 2025

View reviewed changes

library/coretests/tests/result.rs Outdated Show resolved Hide resolved

rustbot assigned RalfJung and unassigned tgross35 Aug 1, 2025

Constify additional Result functions

9377e0a

Randl force-pushed the const-result branch from 0baf3ab to 9377e0a Compare August 1, 2025 05:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 2, 2025

Rollup merge of rust-lang#143771 - Randl:const-result, r=tgross35

9d089e3

Constify some more `Result` functions

samueltardieu mentioned this pull request Aug 2, 2025

Rollup of 18 pull requests #144810

Closed

samueltardieu mentioned this pull request Aug 2, 2025

Rollup of 17 pull requests #144814

Merged

bors merged commit 96b3b83 into rust-lang:master Aug 3, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Aug 3, 2025

rust-timer added a commit that referenced this pull request Aug 3, 2025

Unrolled build for #143771

6961728

Rollup merge of #143771 - Randl:const-result, r=tgross35 Constify some more `Result` functions

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 4, 2025

Rollup merge of rust-lang#143771 - Randl:const-result, r=tgross35

d97f923

Constify some more `Result` functions

Constify some more Result functions #143771

Constify some more Result functions #143771

Uh oh!

Conversation

Randl commented Jul 11, 2025

Uh oh!

rustbot commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Jul 11, 2025

Uh oh!

oli-obk commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnr commented Jul 11, 2025

Uh oh!

oli-obk commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Jul 11, 2025

Uh oh!

tgross35 commented Jul 18, 2025

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

Randl commented Jul 20, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RalfJung commented Aug 1, 2025

Uh oh!

tgross35 commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

Constify some more `Result` functions #143771

Constify some more `Result` functions #143771

oli-obk commented Jul 11, 2025 •

edited

Loading

oli-obk commented Jul 11, 2025 •

edited

Loading