Allow $foo:block nonterminals in expression position #14432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| INTERPOLATED(token::NtExpr(e)) => { | ||
| Some(e) | ||
| } | ||
| INTERPOLATED(token::NtPath(_)) => { | ||
| let pt = maybe_path.take_unwrap(); | ||
| Some($p.mk_expr(($p).span.lo, ($p).span.hi, ExprPath(pt))) | ||
| let pt = match $p.token { |
There was a problem hiding this comment.
Why can't this be part of the outer match?
There was a problem hiding this comment.
Because mk_expr() takes a &mut pointer (for no valid reason except that all of the methods take &mut), so the outstanding reference from ref pt would trigger a borrowck error.
There was a problem hiding this comment.
Oh, I see. I guess we theoretically want to move the token out of p.token to avoid the borrowing and the clone.
r=me if you add a FIXME referencing this (no particular need for an issue).
bors
added a commit
that referenced
this pull request
May 26, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Drop support for non-syroot proc macro ABIs This makes some bigger changes to how we handle the proc-macro-srv things, for one it is now an empty crate if built without the `sysroot-abi` feature, this simplifies some things dropping the need to put the feature cfg in various places. The cli wrapper now actually depends on the server, instead of being part of the server that is just exported, that way we can have a true dummy server that just errors on each request if no sysroot support was specified.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 25, 2025
…4432) To avoid false positives, the `range_plus_one` and `range_minus_one` lints will restrict themselves to situations where the iterator types can be easily switched from exclusive to inclusive or vice-versa. This includes situations where the range is used as an iterator, or is used for indexing. On the other hand, assignments of the range to variables, including automatically typed ones or wildcards, will no longer trigger the lint. However, the cases where such an assignment would benefit from the lint are probably rare. In a second commit, the `range_plus_one` and `range_minus_one` logic are unified, in order to properly emit parentheses around the suggestion when needed. Fix rust-lang/rust-clippy#3307 Fix rust-lang/rust-clippy#9908 changelog: [`range_plus_one`, `range_minus_one`]: restrict lint to cases where it is safe to switch the range type *Edit:* as a consequence, this led to the removal of three `#[expect(clippy::range_plus_one)]` in the Clippy sources to avoid those false positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13678.