Skip to content

Remove hello_world directory #144411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove hello_world directory #144411

wants to merge 1 commit into from
+0 −4

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jul 24, 2025 •
edited by jieyouxu
Loading

Move tests/ui/hello_world/main.rs and retire the single-file tests/ui/hello_world/ directory.

Part of #133895.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@jieyouxu
Copy link
Member

When you do these kind of ui subdirectory changes, can you also make sure to update tests/ui/README.md?

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jul 24, 2025

Sure, one sec

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jul 24, 2025

I believe you've meant SUMMARY.md because there is no tests/ui/README.md

@jieyouxu
Copy link
Member

Er sorry, we'll rename it to README.md in #144340 as that's what usually other test dirs / subdirs use (and not to be confused with mdbook) following feedback.

For this PR yeah it'll be SUMMARY.md.

jieyouxu
jieyouxu reviewed Jul 24, 2025
View reviewed changes
@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jul 24, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2025
jieyouxu
jieyouxu approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bit weird where to put it, warnings/ is fine for now.

@jieyouxu
Copy link
Member

This will merge conflict with #144340, so

@rustbot blocked (on #144340)

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jul 25, 2025 •
edited
Loading

btw meta suggestion: I edited the PR description to better reflect what this PR currently does, it's very helpful to update the PR title/description after changes since the initial version/approach :3

@bors
Copy link
Collaborator

bors commented Jul 25, 2025

☔ The latest upstream changes (presumably #144440) made this pull request unmergeable. Please resolve the merge conflicts.

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jul 25, 2025 •
edited
Loading

will fix this after #144151 (because of conflict)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kivooeo @rustbot @jieyouxu @bors