Assorted rustdoc improvements #14478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of one giant function, this breaks it up into several smaller functions which have explicit dependencies among one another. There are no code changes as a result of this commit.
The cache is going to be used earlier in the HTML generation process, which means that it needs to get into TLS as soon as possible.
When inlining documentation across crates, primitive implementors of traits were not shown. This commit tweaks the infrastructure to treat primitive and Path-like impls the same way, displaying all implementors everywhere. cc rust-lang#14462
|
Updated with @huonw's comment. |
|
I'm gonna just start piling things over into #14513 |
bors
added a commit
that referenced
this pull request
May 31, 2014
This is currently rebased on top of #14478, but that's just to preemptively avoid rebase conflicts and to provide a better preview. This can land independently of that PR. This change crates a dedicated page in rustdoc for primitive types to outline everything you can do with them (at least in a basic way). * Preview - http://people.mozilla.org/~acrichton/doc/ * Exhibit A - http://people.mozilla.org/~acrichton/doc/std/#primitives * Exhibit B - http://people.mozilla.org/~acrichton/doc/std/primitive.str.html * Exhibit C - http://people.mozilla.org/~acrichton/doc/std/primitive.slice.html Please don't hesitate to be nitpickity, it's easy to overlook a thing here or there!
bors
added a commit
that referenced
this pull request
Jun 1, 2014
This is currently rebased on top of #14478, but that's just to preemptively avoid rebase conflicts and to provide a better preview. This can land independently of that PR. This change crates a dedicated page in rustdoc for primitive types to outline everything you can do with them (at least in a basic way). * Preview - http://people.mozilla.org/~acrichton/doc/ * Exhibit A - http://people.mozilla.org/~acrichton/doc/std/#primitives * Exhibit B - http://people.mozilla.org/~acrichton/doc/std/primitive.str.html * Exhibit C - http://people.mozilla.org/~acrichton/doc/std/primitive.slice.html Please don't hesitate to be nitpickity, it's easy to overlook a thing here or there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress being made on #14462