Skip to content

Conversation

fmease
Copy link
Member

@fmease fmease commented Aug 5, 2025

Missed this during my review of #143879, huge apologies!
Fixes [after beta backport] #144958.

cc @fee1-dead
r? @BoxyUwU or anyone

@fmease fmease added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. PG-const-traits Project group: Const traits labels Aug 5, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

⚠️ Warning ⚠️

@fmease
Copy link
Member Author

fmease commented Aug 5, 2025

Not sure if stable-nominated actually makes sense since this hasn't literally hit branch stable yet, only beta. But beta will stable promoted soon / stable artifacts have been built already IIUC.

@jieyouxu
Copy link
Member

jieyouxu commented Aug 5, 2025

Doesn't #143879 target 1.90.0? I.e. I don't think it would hit 1.89.0 stable right? If I got my versions right, it probably would need a beta backport but not a stable backport (?)

@fmease
Copy link
Member Author

fmease commented Aug 5, 2025

Ah ic ic, I didn't realize that the beta I was testing was 1.90. Oof ok

@jieyouxu

This comment was marked as resolved.

@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Aug 5, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 5, 2025

r=me if CI passes

@fmease
Copy link
Member Author

fmease commented Aug 5, 2025

@bors r=BoxyUwU rollup

@bors
Copy link
Collaborator

bors commented Aug 5, 2025

📌 Commit 092c6f3 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
bors added a commit that referenced this pull request Aug 6, 2025
Rollup of 15 pull requests

Successful merges:

 - #144195 (Parser: Recover from attributes applied to types and generic args)
 - #144794 (Port `#[coroutine]` to the new attribute system)
 - #144835 (Anonymize binders in tail call sig)
 - #144861 (Stabilize `panic_payload_as_str` feature)
 - #144917 (Enforce tail call type is related to body return type in borrowck)
 - #144948 (we only merge candidates for trait and normalizes-to goals)
 - #144956 (Gate const trait syntax)
 - #144970 (rustdoc: fix caching of intra-doc links on reexports)
 - #144972 (add code example showing that file_prefix treats dotfiles as the name of a file, not an extension)
 - #144975 (`File::set_times`: Update documentation and example to support setting timestamps on directories)
 - #144977 (Fortify generic param default checks)
 - #144996 (simplifycfg: Mark as changed when start is modified in collapse goto chain)
 - #144998 (mir: Do not modify NonUse in `super_projection_elem`)
 - #145000 (Remove unneeded `stage` parameter when setting up stdlib Cargo)
 - #145008 (Fix rustdoc scrape examples crash)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 48d5756 into rust-lang:master Aug 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 7, 2025
rust-timer added a commit that referenced this pull request Aug 7, 2025
Rollup merge of #144956 - fmease:gate-const-trait-syntax, r=BoxyUwU

Gate const trait syntax

Missed this during my review of #143879, huge apologies!
Fixes [after beta backport] #144958.

cc ``@fee1-dead``
r? ``@BoxyUwU`` or anyone
@fmease fmease deleted the gate-const-trait-syntax branch August 7, 2025 03:16
@apiraino
Copy link
Contributor

apiraino commented Aug 7, 2025

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 7, 2025
@cuviper cuviper mentioned this pull request Aug 21, 2025
@cuviper cuviper modified the milestones: 1.91.0, 1.90.0 Aug 21, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 21, 2025
bors added a commit that referenced this pull request Aug 21, 2025
[beta] backports

- Gate const trait syntax #144956
- Demote x86_64-apple-darwin to Tier 2 with host tools #145252
- Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause #145642

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants