Skip to content

Make config method invoke inside parse use dwn_ctx #145149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 11, 2025
Merged

Make config method invoke inside parse use dwn_ctx #145149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b4675dc
add download_ci_rustc_commit function and invoke from parse_inner
Shourya742 Aug 8, 2025
111a0e8
add parse_download_ci_llvm function and invoke from parse_inner
Shourya742 Aug 8, 2025
7eb8f60
add is_system_llvm function and invoke from parse_inner
Shourya742 Aug 9, 2025
134fcc8
add git_info function and invoke from parse_inner
Shourya742 Aug 9, 2025
2213b7a
add ci_llvm_root function and invoke from parse_inner
Shourya742 Aug 9, 2025
621af4a
add read_file_by_commit function and invoke from parse_inner
Shourya742 Aug 9, 2025
aad54a8
invoke functions from methods
Shourya742 Aug 9, 2025
8612db2
extend download context and change functions to directly use that
Shourya742 Aug 9, 2025
bfa6b56
add review comments
Shourya742 Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/bootstrap/src/core/build_steps/llvm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ pub(crate) fn detect_llvm_freshness(config: &Config, is_git: bool) -> PathFreshn
///
/// This checks the build triple platform to confirm we're usable at all, and if LLVM
/// with/without assertions is available.
pub(crate) fn is_ci_llvm_available_for_target(config: &Config, asserts: bool) -> bool {
pub(crate) fn is_ci_llvm_available_for_target(
host_target: &TargetSelection,
asserts: bool,
) -> bool {
// This is currently all tier 1 targets and tier 2 targets with host tools
// (since others may not have CI artifacts)
// https://doc.rust-lang.org/rustc/platform-support.html#tier-1
Expand Down Expand Up @@ -235,8 +238,8 @@ pub(crate) fn is_ci_llvm_available_for_target(config: &Config, asserts: bool) ->
("x86_64-unknown-netbsd", false),
];

if !supported_platforms.contains(&(&*config.host_target.triple, asserts))
&& (asserts || !supported_platforms.contains(&(&*config.host_target.triple, true)))
if !supported_platforms.contains(&(&*host_target.triple, asserts))
&& (asserts || !supported_platforms.contains(&(&*host_target.triple, true)))
{
return false;
}
Expand Down
Loading
Loading