Make Arc::make_unique check weak refs; add make_unique to Rc #14522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also add tests for |
This patch makes `Arc::make_unique` examine the number of weak references as well as strong references, which is required for safety. It also adds a `make_unique` method to the `Rc` type for consistency. Closes rust-lang#14521.
|
@alexcrichton Added. |
|
@alexcrichton The upgrade can only succeed if there is another strong reference, which would then fail to trigger the original bug. |
|
@alexcrichton Note that, on the other hand, the old Arc would have allowed the current upgrade to go through. |
|
Aha, indeed. Oh well. |
bors
added a commit
that referenced
this pull request
May 30, 2014
…ichton,me This patch makes `Arc::make_unique` examine the number of weak references as well as strong references, which is required for safety. It also adds a `make_unique` method to the `Rc` type for consistency. Closes #14521.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
Arc::make_uniqueexamine the number of weakreferences as well as strong references, which is required for safety.
It also adds a
make_uniquemethod to theRctype for consistency.Closes #14521.