Skip to content

Handle unwinding fatal errors in codegen workers #145814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

Handle unwinding fatal errors in codegen workers #145814

merged 2 commits into from
Aug 26, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 24, 2025

Also directly unwind on fatal errors at the point they are emitted inside the codegen backends.

Fixes the coordinator ICE of #132240, #135075 and #145800.

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@bjorn3 bjorn3 mentioned this pull request Aug 24, 2025
Open
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 24, 2025

Fixes the coordinator ICE of #132240, #135075 and #145800.

Is that enough to close those issues or should they be kept open until underlying reason those object files are missing is known and fixed?

@bjorn3
Directly raise fatal errors inside the codegen backends
525c6a3 
As opposed to passing it around through Result.
@bjorn3 bjorn3 force-pushed the codegen_worker_fatal_error branch from e4813b8 to 525c6a3 Compare August 24, 2025 11:20
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2025

📌 Commit 525c6a3 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2025
@petrochenkov
Copy link
Contributor

Fixes the coordinator ICE of #132240, #135075 and #145800.

Is that enough to close those issues or should they be kept open until underlying reason those object files are missing is known and fixed?

In the compiler output from the linked issues I don't see any hints on what the underlying issue is.
Perhaps close the issues now, and ask the authors to make a new issue with the new compiler output once this change is released?

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 25, 2025 •
edited
Loading

In all cases it would remove the ICE while keeping the error: cached cgu be5oc9yxgopg7ilp0e3j30unl should have an object file, but doesn't. No additional errors or ICE should be produced. By the time this error is emitted, any knowledge by rustc about what the issue could be is gone. The root cause likely occurs during the previous compilation.

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 25, 2025
@jhpratt
Rollup merge of rust-lang#145814 - bjorn3:codegen_worker_fatal_error,…
1cedceb 
… r=petrochenkov

Handle unwinding fatal errors in codegen workers

Also directly unwind on fatal errors at the point they are emitted inside the codegen backends.

Fixes the coordinator ICE of rust-lang#132240, rust-lang#135075 and rust-lang#145800.
@jhpratt jhpratt mentioned this pull request Aug 25, 2025
Closed
bors added a commit that referenced this pull request Aug 25, 2025
@bors
Auto merge of #145860 - jhpratt:rollup-w1oo0ci, r=jhpratt
036a5ec 
Rollup of 12 pull requests

Successful merges:

 - #143193 (Port `#[link]` to the new attribute parsing infrastructure )
 - #144373 (remove deprecated Error::description in impls)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 26, 2025
@Zalathar
Rollup merge of rust-lang#145814 - bjorn3:codegen_worker_fatal_error,…
8741485 
… r=petrochenkov

Handle unwinding fatal errors in codegen workers

Also directly unwind on fatal errors at the point they are emitted inside the codegen backends.

Fixes the coordinator ICE of rust-lang#132240, rust-lang#135075 and rust-lang#145800.
@Zalathar Zalathar mentioned this pull request Aug 26, 2025
Closed
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145865 - Zalathar:rollup-x7wk361, r=Zalathar
f38bc02 
Rollup of 13 pull requests

Successful merges:

 - #143193 (Port `#[link]` to the new attribute parsing infrastructure )
 - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)
 - #145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Aug 26, 2025
Merged
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145871 - Zalathar:rollup-lag9tlg, r=Zalathar
d2ec14c 
Rollup of 12 pull requests

Successful merges:

 - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)
 - #145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145871 - Zalathar:rollup-lag9tlg, r=Zalathar
4356e83 
Rollup of 12 pull requests

Successful merges:

 - #143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - #145535 (make rustdoc::invalid_html_tags more robust)
 - #145766 (test(rustfmt): Verify frontmatter is preserved)
 - #145811 (Fix some minor issues in comments)
 - #145814 (Handle unwinding fatal errors in codegen workers)
 - #145815 (Wait for DPkg frontend lock when trying to remove packages)
 - #145821 (compiletest: if a compiler fails, show its output)
 - #145845 (Make `x test distcheck` self-contained)
 - #145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - #145856 (Update books)
 - #145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f563309 into rust-lang:master Aug 26, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 26, 2025
rust-timer added a commit that referenced this pull request Aug 26, 2025
@rust-timer
Unrolled build for #145814
a015993 
Rollup merge of #145814 - bjorn3:codegen_worker_fatal_error, r=petrochenkov

Handle unwinding fatal errors in codegen workers

Also directly unwind on fatal errors at the point they are emitted inside the codegen backends.

Fixes the coordinator ICE of #132240, #135075 and #145800.
@bjorn3 bjorn3 deleted the codegen_worker_fatal_error branch August 26, 2025 11:43
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Aug 28, 2025
@bors
Auto merge of #145871 - Zalathar:rollup-lag9tlg, r=Zalathar
c4920e1 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#143689 (Allow linking a prebuilt optimized compiler-rt builtins library)
 - rust-lang/rust#144885 (Implement some more checks in `ptr_guaranteed_cmp`. )
 - rust-lang/rust#145535 (make rustdoc::invalid_html_tags more robust)
 - rust-lang/rust#145766 (test(rustfmt): Verify frontmatter is preserved)
 - rust-lang/rust#145811 (Fix some minor issues in comments)
 - rust-lang/rust#145814 (Handle unwinding fatal errors in codegen workers)
 - rust-lang/rust#145815 (Wait for DPkg frontend lock when trying to remove packages)
 - rust-lang/rust#145821 (compiletest: if a compiler fails, show its output)
 - rust-lang/rust#145845 (Make `x test distcheck` self-contained)
 - rust-lang/rust#145847 (Don't show warnings from xcrun with -Zverbose-internals)
 - rust-lang/rust#145856 (Update books)
 - rust-lang/rust#145858 (Update wasm-component-ld dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
@bjorn3 bjorn3 mentioned this pull request Oct 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bjorn3 @rustbot @petrochenkov @bors