Port limit attributes to the new attribute parsing infrastructure #145819

jdonszelmann · 2025-08-24T12:40:32Z

Doesn't pass tests, to be rebased on #145792 which will solve that

r? @fmease

rustbot · 2025-08-24T12:40:37Z

fmease is not on the review rotation at the moment.
They may take a while to respond.

scrabsha · 2025-08-24T17:57:43Z

@jdonszelmann #145792 is mostly ready so you can probably rebase now :3

rustbot · 2025-08-28T10:27:28Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

jdonszelmann · 2025-08-28T10:40:32Z

does conflict with #145937 but it's an easy rebase so we'll just see what merges first

jdonszelmann · 2025-08-28T10:44:34Z

tests/ui/recursion_limit/invalid_digit.stderr

@@ -6,15 +6,5 @@ LL | #![recursion_limit = "-100"]
   |                      |
   |                      not a valid integer

-error: `limit` must be a non-negative integer
-  --> $DIR/invalid_digit.rs:3:1
-   |


this doubled up error cannot be prevented. If we do, we'd get a similar situation as with crate_name where we either forget some cases, or delay as bug giving an ice when this literal happens to be a macro that before expansion is invalid but expanded is valid. e.g. concat!("100") which before expansion is an expression we should reject but after expansion is a perfectly valid integer literal

It's not doubled up? Your PR removes duplication looking at the diff. Am I missing something?

fmease · 2025-08-28T14:51:38Z

I presume this fixes some of these reported ICEs: #145922? You don't need to add regression tests, not worth it I think.

bors · 2025-08-28T18:00:57Z

☔ The latest upstream changes (presumably #145958) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-08-28T20:19:00Z

I think the ices are already mostly fixed because we don't delay bugs anymore for this specific case. So I think it's fixed without this pr but we'll want this anyway

…structure

rustbot · 2025-08-29T06:43:03Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2025-08-29T12:05:45Z

@rustbot ready

fmease

r=me after nits

View changes since this review

compiler/rustc_attr_parsing/src/attributes/crate_level.rs

compiler/rustc_attr_parsing/src/context.rs

fmease · 2025-08-29T17:43:09Z

compiler/rustc_interface/src/passes.rs

@@ -1245,7 +1246,8 @@ pub fn get_crate_name(sess: &Session, krate_attrs: &[ast::Attribute]) -> Symbol
    // in all code paths that require the crate name very early on, namely before
    // macro expansion.

-    let attr_crate_name = parse_crate_name(sess, krate_attrs, ShouldEmit::EarlyFatal);
+    let attr_crate_name =
+        parse_crate_name(sess, krate_attrs, ShouldEmit::EarlyFatal { also_emit_lints: true });


Ah, cool! You've (added &) set also_emit_lints to true for warning on e.g., duplicate #![crate_names], is that correct?

I've experimented a bit and noticed that printf '#![crate_name = "x"]#![crate_name="x"]' | rustc +master-2025-08-29 - --print=crate-name doesn't emit any warning on master. Does your change incidentally fix that? (It does emit during normal execution)

it doesn't fix cause here we never get to the point where we emit buffered lints I think hehe

early lints are emitted and buffered but they never appear

compiler/rustc_interface/src/passes.rs

fmease · 2025-08-29T17:49:36Z

tests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.stderr

+LL | #[recursion_limit="0200"]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+note: This attribute does not have an `!`, which means it is applied to this module


(preexisting) The This should be lower-case, https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-output-style-guide, can be fixed in a different PR.

fmease · 2025-08-29T17:52:11Z

tests/ui/recursion_limit/invalid_digit.stderr

@@ -6,15 +6,5 @@ LL | #![recursion_limit = "-100"]
   |                      |
   |                      not a valid integer

-error: `limit` must be a non-negative integer
-  --> $DIR/invalid_digit.rs:3:1
-   |


It's not doubled up? Your PR removes duplication looking at the diff. Am I missing something?

rustbot assigned fmease Aug 24, 2025

jdonszelmann changed the title ~~Convert limits~~ Port limit attributes to the new attribute parsing infrastructure Aug 24, 2025

jdonszelmann mentioned this pull request Aug 24, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

jdonszelmann force-pushed the convert-limits branch from 835549e to 995056a Compare August 28, 2025 10:26

jdonszelmann marked this pull request as ready for review August 28, 2025 10:27

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2025

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the convert-limits branch from 995056a to 11da338 Compare August 28, 2025 10:39

jdonszelmann commented Aug 28, 2025

View reviewed changes

jdonszelmann force-pushed the convert-limits branch from 11da338 to 06599a5 Compare August 28, 2025 10:46

fmease mentioned this pull request Aug 28, 2025

add doc-hidden to exports in attribute prelude #145937

Merged

jdonszelmann added 5 commits August 29, 2025 08:41

port #[recursion_limit] to the new attribute parsing infrastructure

68ae80b

port #[move_size_limit] to the new attribute parsing infrastructure

31d08dd

port #[type_length_limit] to the new attribute parsing infrastructure

58e76a0

port #[pattern_complexity_limit] to the new attribute parsing infra…

23503ad

…structure

fixup limit handling code

1de3926

jdonszelmann force-pushed the convert-limits branch from 06599a5 to 1de3926 Compare August 29, 2025 06:43

fmease approved these changes Aug 29, 2025

View reviewed changes

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2025

Port limit attributes to the new attribute parsing infrastructure #145819

Are you sure you want to change the base?

Port limit attributes to the new attribute parsing infrastructure #145819

Conversation

jdonszelmann commented Aug 24, 2025

Uh oh!

rustbot commented Aug 24, 2025

Uh oh!

This comment has been minimized.

scrabsha commented Aug 24, 2025

Uh oh!

This comment was marked as resolved.

rustbot commented Aug 28, 2025

Uh oh!

This comment has been minimized.

jdonszelmann commented Aug 28, 2025

Uh oh!

jdonszelmann Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

fmease Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

fmease commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

jdonszelmann commented Aug 28, 2025

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

jdonszelmann commented Aug 29, 2025

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fmease Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 31, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fmease Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 31, 2025

Choose a reason for hiding this comment

Uh oh!

fmease Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fmease left a comment •

edited by rustbot

Loading

fmease Aug 29, 2025 •

edited

Loading