Skip to content

editorconfig: don't use nonexistent syntax #145823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

editorconfig: don't use nonexistent syntax #145823

merged 1 commit into from
Sep 3, 2025

Conversation

lolbinarycat
Copy link
Contributor

reading through the editorconfig spec, using ! to negate an entire glob is simply not a feature.

you can use ! to negate a charachter class, but that's not what was going on here.

@lolbinarycat
editorconfig: don't use nonexistant syntax
3b627b5 
reading through the editorconfig spec, using `!` to negate
an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not
what was going on here.
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2025
@workingjubilee
Copy link
Member

got a link to the editorconfig spec?

@lolbinarycat
Copy link
Contributor Author

https://spec.editorconfig.org/#glob-expressions

@joshtriplett joshtriplett changed the title editorconfig: don't use nonexistant syntax editorconfig: don't use nonexistent syntax Aug 24, 2025
@workingjubilee
Copy link
Member

I wonder if they misinterpreted [!seq].

Or maybe it's just their editor recognizes it as an extension.

@lolbinarycat
Copy link
Contributor Author

I certainly misinterpreted [!seq] when I added the second instance, (the !tests/ one), but that's mainly because I didn't consider "what if the existing config is actually wrong" as a real possibility.

@GuillaumeGomez
Copy link
Member

Seems all good to me, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 2, 2025

📌 Commit 3b627b5 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 2, 2025
@GuillaumeGomez
Rollup merge of rust-lang#145823 - lolbinarycat:editorconfig-fix, r=G…
eaec4cc 
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 2, 2025
@GuillaumeGomez
Rollup merge of rust-lang#145823 - lolbinarycat:editorconfig-fix, r=G…
1f67add 
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 2, 2025
Closed
bors added a commit that referenced this pull request Sep 2, 2025
@bors
Auto merge of #146139 - GuillaumeGomez:rollup-urehddd, r=GuillaumeGomez
05d62d3 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145962 (Ensure we emit an allocator shim when only some crate types need one)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146090 (Derive `PartialEq` for `InvisibleOrigin`)
 - #146120 (Correct typo in `rustc_errors` comment)
 - #146121 (fix: Filter suggestion parts that match existing code)
 - #146134 (llvm: nvptx: Layout update to match LLVM)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 3, 2025
@tgross35
Rollup merge of rust-lang#145823 - lolbinarycat:editorconfig-fix, r=G…
db2af4b 
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.
@tgross35 tgross35 mentioned this pull request Sep 3, 2025
Closed
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146141 - tgross35:rollup-vx6hx6n, r=tgross35
08780cf 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146141 - tgross35:rollup-vx6hx6n, r=tgross35
6267c26 
Rollup of 8 pull requests

Successful merges:

 - #139113 (unstable book: in a sanitizer example, check the code)
 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 3, 2025
@Zalathar
Rollup merge of rust-lang#145823 - lolbinarycat:editorconfig-fix, r=G…
867849d 
…uillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.
@Zalathar Zalathar mentioned this pull request Sep 3, 2025
Closed
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146157 - Zalathar:rollup-0w8r7g6, r=Zalathar
0cae2f9 
Rollup of 9 pull requests

Successful merges:

 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )
 - #146112 (don't uppercase error messages)
 - #146154 (CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Sep 3, 2025
Merged
bors added a commit that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146160 - Zalathar:rollup-qxphx7g, r=Zalathar
fd75a9c 
Rollup of 8 pull requests

Successful merges:

 - #145279 (Constify conversion traits (part 1))
 - #145414 (unicode-table-generator refactors)
 - #145823 (editorconfig: don't use nonexistent syntax)
 - #145944 (std: Start supporting WASIp2 natively )
 - #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
 - #146032 (Explicity disable LSX feature for `loongarch64-unknown-none` target)
 - #146106 (fix(lexer): Only allow horizontal whitespace in frontmatter )
 - #146154 (CI: rfl: move job forward to Linux v6.17-rc3 plus 2 commits)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7f6310 into rust-lang:master Sep 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 3, 2025
rust-timer added a commit that referenced this pull request Sep 3, 2025
@rust-timer
Unrolled build for #145823
7c2a6ba 
Rollup merge of #145823 - lolbinarycat:editorconfig-fix, r=GuillaumeGomez

editorconfig: don't use nonexistent syntax

reading through the editorconfig spec, using `!` to negate an entire glob is simply not a feature.

you can use `!` to negate a charachter class, but that's not what was going on here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lolbinarycat @rustbot @workingjubilee @GuillaumeGomez @bors @Mark-Simulacrum