Stabilize fmt::from_fn
#145915
Open
Stabilize fmt::from_fn
#145915
+12
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? libs-api |
rustbot
added
the
T-libs-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm not 100%, but I'm pretty sure I've seen precedent for splitting a feature and stabilizing it in one PR, but if I'm wrong on that let me know and I can make a separate tracking issue and stuff.)
I propose to stabilize a subset of #117729; specifically,
fmt::from_fn, since it seems to have the least controversy and most utility. This API is already seeing heavy use in librustdoc, and the implementation is the obvious one way to go about it. There was some discussion in the issue of whetherfmt::FromFnshould implementfmt::{UpperHex, LowerHex, etc}, and that point seemed to be resolved, but if desired in the future those could be added as a non-breaking change.