Skip to content

Stabilize fmt::from_fn #145915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2025
Merged

Stabilize fmt::from_fn #145915

merged 4 commits into from
Nov 4, 2025

Conversation

@coolreader18
Copy link
Contributor

@coolreader18 coolreader18 commented Aug 27, 2025 •
edited
Loading

Resolves #146705, pending its FCP.

As discussed in that tracking issue and #117729, this splits fmt::from_fn out from the debug_closure_helpers feature.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 27, 2025
@Kobzol
Copy link
Member

Kobzol commented Aug 27, 2025

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 27, 2025
@rustbot rustbot assigned m-ou-se and unassigned thomcc Aug 27, 2025
@bors
Copy link
Collaborator

bors commented Aug 30, 2025

☔ The latest upstream changes (presumably #146023) made this pull request unmergeable. Please resolve the merge conflicts.

@jmillikin
Copy link
Contributor

jmillikin commented Sep 1, 2025

(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature.

(2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out from_fn?

I would be thrilled to have someone with sufficient permissions start an FCP for debug_closure_helpers.

@coolreader18
Copy link
Contributor Author

coolreader18 commented Sep 1, 2025

(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature.

I think that's true, but I was imagining that the FCP would just happen here.

(2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out from_fn?

I'd be fine with that - hopefully someone will start an FCP there.

@coolreader18
Copy link
Contributor Author

coolreader18 commented Sep 1, 2025

I'm closing this for now with the idea that the full feature will hopefully get FCP'd.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2025
This was referenced Sep 17, 2025
Open
Closed
@coolreader18 coolreader18 reopened this Sep 19, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Sep 27, 2025

☔ The latest upstream changes (presumably #146636) made this pull request unmergeable. Please resolve the merge conflicts.

@jmillikin
Copy link
Contributor

jmillikin commented Oct 31, 2025

r? libs-api

per rust-lang/team#2003

@rustbot rustbot assigned dtolnay and unassigned m-ou-se Oct 31, 2025
dtolnay
dtolnay approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

View changes since this review

@dtolnay
Copy link
Member

dtolnay commented Nov 4, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

📌 Commit 93c8bf1 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#145915 - coolreader18:stabilize-fmt_from_fn…
96db472 
…, r=dtolnay

Stabilize `fmt::from_fn`

Resolves rust-lang#146705, pending its FCP.

As discussed in that tracking issue and rust-lang#117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148458 - Zalathar:rollup-2xmquy0, r=Zalathar
11e10a4 
Rollup of 10 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #143037 (Make named asm_labels lint not trigger on hexagon register spans)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 4, 2025
@Zalathar
Rollup merge of rust-lang#145915 - coolreader18:stabilize-fmt_from_fn…
6e6a7b3 
…, r=dtolnay

Stabilize `fmt::from_fn`

Resolves rust-lang#146705, pending its FCP.

As discussed in that tracking issue and rust-lang#117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Closed
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148460 - Zalathar:rollup-kihb2hz, r=Zalathar
3b24bf2 
Rollup of 9 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Nov 4, 2025
Merged
bors added a commit that referenced this pull request Nov 4, 2025
@bors
Auto merge of #148462 - Zalathar:rollup-6gckwu6, r=Zalathar
90b6588 
Rollup of 8 pull requests

Successful merges:

 - #133149 (Provide more context on `Fn` closure modifying binding)
 - #145915 (Stabilize `fmt::from_fn`)
 - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool)
 - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`)
 - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored)
 - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`)
 - #148448 (Update books)
 - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 22e4575 into rust-lang:master Nov 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 4, 2025
rust-timer added a commit that referenced this pull request Nov 4, 2025
@rust-timer
Unrolled build for #145915
5ceb8e2 
Rollup merge of #145915 - coolreader18:stabilize-fmt_from_fn, r=dtolnay

Stabilize `fmt::from_fn`

Resolves #146705, pending its FCP.

As discussed in that tracking issue and #117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.
@bors
Copy link
Collaborator

bors commented Nov 4, 2025

⌛ Testing commit 93c8bf1 with merge 90b6588...

@Kobzol
Copy link
Member

Kobzol commented Nov 4, 2025

@bors r-

Stop bors, this is already merged.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2025
@folkertdev
Copy link
Contributor

folkertdev commented Nov 4, 2025

Seemingly that did not stop bors?

@Zalathar
Copy link
Member

Zalathar commented Nov 4, 2025

@bors ping

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

😪 I'm awake I'm awake

@Zalathar
Copy link
Member

Zalathar commented Nov 4, 2025

@bors r- retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 4, 2025
@coolreader18 coolreader18 deleted the stabilize-fmt_from_fn branch November 4, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for fmt_from_fn