stabilize extern_system_varargs #145954
Open
stabilize extern_system_varargs #145954
+127
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
RalfJung
force-pushed
the
syscall-c-variadics
branch
from
169a301 to
3e03e56
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
syscall-c-variadics
branch
from
3e03e56 to
09dd913
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
syscall-c-variadics
branch
from
09dd913 to
0946e8b
Compare
traviscross
added
the
I-lang-radar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #144066. This has been already FCP'd over there, but @workingjubilee has some concerns regarding "system" varargs specifically (IIUC).