Skip to content

resolve: Refactor struct ExternPreludeEntry #146004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

resolve: Refactor struct ExternPreludeEntry #146004

merged 2 commits into from
Sep 1, 2025

Conversation

petrochenkov
Copy link
Contributor

Avoid impossible combinations of fields and apply the first part of #144737 (do not resolve erroneous entries repeatedly, keep them as PendingBinding::Ready(None) instead).

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2025
@petrochenkov petrochenkov mentioned this pull request Aug 29, 2025
Open
@nnethercote
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 31, 2025

📌 Commit f0dbfad has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 1, 2025
@Zalathar
Rollup merge of rust-lang#146004 - petrochenkov:epentry, r=nnethercote
cb1ef5f 
resolve: Refactor `struct ExternPreludeEntry`

Avoid impossible combinations of fields and apply the first part of rust-lang#144737 (do not resolve erroneous entries repeatedly, keep them as `PendingBinding::Ready(None)` instead).
@Zalathar Zalathar mentioned this pull request Sep 1, 2025
Merged
bors added a commit that referenced this pull request Sep 1, 2025
@bors
Auto merge of #146072 - Zalathar:rollup-0svnrfe, r=Zalathar
be4e9b7 
Rollup of 6 pull requests

Successful merges:

 - #145421 (`dump_mir` cleanups)
 - #145968 (Add `Bound::copied`)
 - #146004 (resolve: Refactor `struct ExternPreludeEntry`)
 - #146042 (Detect negative literal inferred to unsigned integer)
 - #146046 (Suggest method name with maybe ty mismatch)
 - #146051 (Change std f32 test to pass under Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5adc0fe into rust-lang:master Sep 1, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 1, 2025
rust-timer added a commit that referenced this pull request Sep 1, 2025
@rust-timer
Unrolled build for #146004
83ccfb9 
Rollup merge of #146004 - petrochenkov:epentry, r=nnethercote

resolve: Refactor `struct ExternPreludeEntry`

Avoid impossible combinations of fields and apply the first part of #144737 (do not resolve erroneous entries repeatedly, keep them as `PendingBinding::Ready(None)` instead).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
4 participants
@petrochenkov @rustbot @nnethercote @bors