Skip to content

Implement Receiver for Exclusive #146009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement Receiver for Exclusive #146009

wants to merge 2 commits into from
+27 −12

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Aug 29, 2025 •
edited by rustbot
Loading

In the hope of being able to implement DerefMut in the future.

Changes Exclusive's methods to associated functions.

cc #98407

@rustbot label T-libs-api

@Jules-Bertholet
Implement Receiver for Exclusive
a33f913 
In the hope of being able to implement `DerefMut` in the future.

Changes `Exclusive`'s methods to associated functions.
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 29, 2025
@tgross35 tgross35 mentioned this pull request Sep 2, 2025
Open
5 tasks
tgross35
tgross35 reviewed Sep 2, 2025
View reviewed changes
library/core/src/sync/exclusive.rs Outdated
}
}

// FIXME: implement `DerefMut` when this becomes possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't immediately obvious how/why this is blocked and what would make it possible, could you link to your comment explaining it on the tracking issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tgross35
Copy link
Contributor

tgross35 commented Sep 2, 2025

Nominated for libs-api #98407 (comment)

@tgross35 tgross35 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2025
@bors
Copy link
Collaborator

bors commented Sep 28, 2025

☔ The latest upstream changes (presumably #147128) made this pull request unmergeable. Please resolve the merge conflicts.

@Amanieu Amanieu added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Oct 1, 2025
@Urgau Urgau added S-waiting-on-libs-api Status: Awaiting decision from T-libs-api and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 left review comments

Assignees

@tgross35 tgross35

Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-libs-api Status: Awaiting decision from T-libs-api T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jules-Bertholet @rustbot @tgross35 @bors @Amanieu @Urgau